cppdepend
report summary
application nameDoom3 (v1.0.0.0)report build date03/16/2017 16:43:59analysis duration01:09:06cppdepend
version
2017.1.0.8903 Professional Developer Editionbaseline for comparisonBaseline is same code base snapshot.code coverage data
Not Defined. To import Code Coverage Data, please read this online documentation.
Get started.Quick tips.Back to CppDepend.
The present HTML report is a summary of data gathered by the analysis.
It is recommended to use the CppDepend interactive UI capabilities
to make the most of CppDepend by mastering all aspects of your code.
It is recommended to use the CppDepend interactive UI capabilities
to make the most of CppDepend by mastering all aspects of your code.
Diagrams
Application Metrics
Note: Further Application Statistics are available.
|
Quality Gates summary
902
Some Quality Gates fail. The buildcan be stopped upon quality gate
failure. Online documentation.
Quality Gates that measure diff cannotbe run on the baseline. Hence they
have blank trend and baseline status.
| Name | Trend | Baseline Value | Value | Group | |||
|---|---|---|---|---|---|---|---|
|  N/A because no coverage data | Project Rules \ Quality Gates | |||||
| N/A because no coverage data | Project Rules \ Quality Gates | |||||
| N/A because no coverage data | Project Rules \ Quality Gates | |||||
|  | 0 issues | 0 issues | Project Rules \ Quality Gates | |||
| |  21 issues | 21 issues | Project Rules \ Quality Gates | |||
| 0 issues | Project Rules \ Quality Gates | |||||
| | 3 rules | 3 rules | Project Rules \ Quality Gates | |||
| | 10.54 % | 10.54 % | Project Rules \ Quality Gates | |||
| 0 man-days | Project Rules \ Quality Gates | |||||
| | 0 namespaces | 0 namespaces | Project Rules \ Quality Gates | |||
| 0 man-days | Project Rules \ Quality Gates |
Rules summary
247253- Number of Rules or Queries with Error (syntax error, exception thrown, time-out): 0
- Number of Rules violated: 28
Rules can be checked from withinVisualCppDepend.
Online documentation.
Rules that rely on diff cannot berun on the baseline. Hence they
have blank # Issues Fixed or Added.
| Name | # Issues | Added | Fixed | Elements | Group | |||
|---|---|---|---|---|---|---|---|---|
| 256 | 0 | 0 | types | Project Rules \ Code Smells | |||
| 255 | 0 | 0 | types | Project Rules \ Code Smells | |||
| 164 | 0 | 0 | types | Project Rules \ Code Smells | |||
| 1811 | 0 | 0 | methods | Project Rules \ Code Smells | |||
| 204 | 0 | 0 | methods | Project Rules \ Code Smells | |||
| 291 | 0 | 0 | methods | Project Rules \ Code Smells | |||
| 195 | 0 | 0 | methods | Project Rules \ Code Smells | |||
| 1957 | 0 | 0 | methods | Project Rules \ Code Smells | |||
| 101 | 0 | 0 | types | Project Rules \ Code Smells | |||
| 16 | 0 | 0 | types | Project Rules \ Object Oriented Design | |||
| 186 | 0 | 0 | types | Project Rules \ Object Oriented Design | |||
| 3 | 0 | 0 | methods | Project Rules \ Object Oriented Design | |||
| 636 | 0 | 0 | fields | Project Rules \ Object Oriented Design | |||
| 20 | 0 | 0 | types | Project Rules \ Object Oriented Design | |||
| 188 | 0 | 0 | types | Project Rules \ Object Oriented Design | |||
| 5 | 0 | 0 | projects | Project Rules \ Object Oriented Design | |||
| 1 | 0 | 0 | project | Project Rules \ Object Oriented Design | |||
| 32 | 0 | 0 | types | Project Rules \ Object Oriented Design | |||
| 55 | 0 | 0 | types | Project Rules \ Dead Code | |||
| 103 | 0 | 0 | methods | Project Rules \ Dead Code | |||
| 68 | 0 | 0 | fields | Project Rules \ Dead Code | |||
| 10 | 0 | 0 | fields | Project Rules \ Naming Conventions | |||
| 10 | 0 | 0 | fields | Project Rules \ Naming Conventions | |||
| 6 | 0 | 0 | types | Project Rules \ Naming Conventions | |||
| 10 | 0 | 0 | types | Project Rules \ Naming Conventions | |||
| 4 | 0 | 0 | types | Project Rules \ Naming Conventions | |||
| 52 | 0 | 0 | methods | Project Rules \ Naming Conventions | |||
| 7 | 0 | 0 | fields | Project Rules \ Naming Conventions |
Application Statistics
| Stat | # Occurences | Avg | StdDev | Max |
|---|---|---|---|---|
| Properties on interfaces | interfaces | 0 | 0 | -1 properties on |
| Methods on interfaces | interfaces | 0 | 0 | -1 methods on |
| Arguments on methods on interfaces | methods | 0 | 0 | -1 arguments on |
| Public properties on classes | 967 Classes | 0.49 | 11.26 | 307 public properties on __Globals |
| Public methods on classes | 967 classes | 24.96 | 98.29 | 2919 public methods on __Globals |
| Arguments on public methods on classes | 24,132 methods | 1.13 | 1.35 | 16 arguments on idMat4.idMat4(constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat,constfloat) |
| IL instructions in non-abstract methods | 27,910 methods | 0.25 | 0.65 | 17 IL instructions in __Globals.TestDot() |
| Cyclomatic complexity on non abstract Methods | 27,910 Methods | 0.39 | 1.37 | CC = 42 for idWindow.Parse(idParser*,bool) |
Projects Metrics
If you wish to define thresholds on Projects' Code Metrics, consider writing some Rules.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
| Projects | # lines of code | # IL instruction | # Types | # Abstract Types | # lines of comment | % Comment | % Coverage | Afferent Coupling | Efferent Coupling | Relational Cohesion | Instability | Abstractness | Distance |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| libs v1.0.0.0 | 0 | 0 | 0 | 0 | 0 | 0 | - | 0 | 0 | 0 | 0 | 0 | 0 |
| exes v1.0.0.0 | 0 | 0 | 0 | 0 | 0 | 0 | - | 0 | 0 | 0 | 0 | 0 | 0 |
| dlls v1.0.0.0 | 0 | 0 | 0 | 0 | 0 | 0 | - | 0 | 0 | 0 | 0 | 0 | 0 |
| idLib v1.0.0.0 | 28033 | 1025 | 113 | 2 | 10589 | 27,41702 | - | 912 | 20 | 3.99 | 0.02 | 0.03 | 0.67 |
| TypeInfo v1.0.0.0 | 5111 | 134 | 63 | 0 | 2689 | 34,47436 | - | 22 | 51 | 1.48 | 0.7 | 0.02 | 0.2 |
| Game v1.0.0.0 | 46666 | 950 | 367 | 4 | 26950 | 36,60889 | - | 25 | 154 | 7.14 | 0.86 | 0.01 | 0.09 |
| CurlLib v1.0.0.0 | 9103 | 118 | 63 | 0 | 5427 | 37,35031 | - | 1 | 38 | 1.3 | 0.97 | 0 | 0.02 |
| DoomDLL v1.0.0.0 | 128012 | 3718 | 1014 | 17 | 51716 | 28,77459 | - | 0 | 381 | 2.94 | 1 | 0.02 | 0.01 |
| MayaImport v1.0.0.0 | 1259 | 42 | 23 | 0 | 457 | 26,6317 | - | 0 | 20 | 1.27 | 1 | 0 | 0 |
| Game-d3xp v1.0.0.0 | 54656 | 1038 | 401 | 5 | 30495 | 35,81285 | - | 0 | 160 | 7.46 | 1 | 0.01 | 0.01 |
Types Metrics
If the code base analyzed has too many types, CppDepend doesn't list Types Metrics to avoid a too big report. The section Types Metrics can be activated by unchecking the option: CppDepend Project Properties > Report > Avoid too big report for large code base > Hide section Types Metrics if... It is recommended to use the CppDepend interactive UI capabilities to browse large applications. |
Namespaces Metrics
If you wish to define thresholds on namespaces' Code Metrics, consider writing some Code Rules.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
Clicking column header arrows sorts values.
Clicking column header title text redirect to the online Code Metric definition.
| Namespaces | # lines of code | # IL instruction | # Types | # lines of comment | % Comment | % Coverage | Afferent Coupling | Efferent Coupling |
|---|---|---|---|---|---|---|---|---|
| idLib::GlobalNamespace | 28033 | 1025 | 113 | 0 | 0 | - | 5 | 1 |
| TypeInfo::GlobalNamespace | 5111 | 134 | 63 | 0 | 0 | - | 2 | 3 |
| Game::GlobalNamespace | 46666 | 950 | 367 | 0 | 0 | - | 1 | 3 |
| CurlLib::GlobalNamespace | 9103 | 118 | 63 | 0 | 0 | - | 1 | 2 |
| DoomDLL::GlobalNamespace | 128012 | 3718 | 1014 | 0 | 0 | - | 0 | 9 |
| MayaImport::GlobalNamespace | 1259 | 42 | 23 | 0 | 0 | - | 0 | 5 |
| Game-d3xp::GlobalNamespace | 54656 | 1038 | 401 | 0 | 0 | - | 0 | 3 |
| Project Rules | 902 |
| Quality Gates | 902 |
|
 | Quality Gate Pass: Percentage Code Coverage |
• Quality Gate Description:
Code coverage is a measure used to describe the degree to which the source code of a program is tested by a particular test suite. A program with high code coverage, measured as a percentage, has had more of its source code executed during testing which suggests it has a lower chance of containing undetected software bugs compared to a program with low code coverage.
Code coverage is certainly the most important quality code metric. But coverage is not enough the team needs to ensure that results are checked at test-time. These checks can be done both in test code, and in application code through assertions. The important part is that a test must fail explicitely when a check gets unvalidated during the test execution.
This quality gate define a warn threshold (70%) and a fail threshold (80%). These are indicative thresholds and in practice the more the better. To achieve high coverage and low risk, make sure that new and refactored classes gets 100% covered by tests and that the application and test code contains as many checks/assertions as possible.
Scalar Result: N/A %
| Quality Gate Pass: Percentage Coverage on New Code |
• Quality Gate Description:
New Code is defined as methods added since the baseline.
To achieve high code coverage it is essential that new code gets properly tested and covered by tests. It is advised that all non-UI new classes gets 100% covered.
Typically 90% of a class is easy to cover by tests and 10% is hard to reach through tests. It means that this 10% remaining is not easily testable, which means it is not well designed, which often means that this code is especially error-prone. This is the reason why it is important to reach 100% coverage for a class, to make sure that potentially error-prone code gets tested.
Scalar Result: N/A %
| Quality Gate Pass: Percentage Coverage on Refactored Code |
• Quality Gate Description:
Refactored Code is defined as methods where code was changed since the baseline.
Comment changes and formatting changes are not considerd as refactoring.
To achieve high code coverage it is essential that refactored code gets properly tested and covered by tests. It is advised that when refactoring a class or a method, it is important to also write tests to make sure it gets 100% covered.
Typically 90% of a class is easy to cover by tests and 10% is hard to reach through tests. It means that this 10% remaining is not easily testable, which means it is not well designed, which often means that this code is especially error-prone. This is the reason why it is important to reach 100% coverage for a class, to make sure that potentially error-prone code gets tested.
Scalar Result: N/A %
| Quality Gate Pass: Blocker Issues |
• Quality Gate Description:
An issue with the severity Blocker cannot move to production, it must be fixed.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
No issue matched
 | Quality Gate Fail: Critical Issues |
• Quality Gate Description:
An issue with a severity level Critical shouldn't move to production. It still can for business imperative needs purposes, but at worst it must be fixed during the next iterations.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
21 issues matched
| 21 issues | Severity | Debt | Annual Interest | Full Name |
|---|---|---|---|---|
| Critical issue on: idPlayer | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idPlayer | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idAI | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idCollisionModelManagerLocal | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idGameLocal | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idMatX | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idGameLocal | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idMultiplayerGame | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idSessionLocal | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: CMainFrame | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idSIMD_SSE | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: idRenderWorldLocal | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types too big |
| Critical issue on: CMainFrame | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idAI | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idAI | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idPlayer | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idEntity | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idEntity | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idPlayer | Critical | 1d 2h | 2h 0min | Rule violated: Avoid types with too many methods |
| Critical issue on: idMat6.InverseSelf() | Critical | 6h 0min | 2h 0min | Rule violated: Avoid methods with too many local variables |
| Critical issue on: idMat5.InverseSelf() | Critical | 6h 0min | 2h 0min | Rule violated: Avoid methods with too many local variables |
Statistics
| Stat | Severity | Debt | Annual Interest |
|---|---|---|---|
| Sum: | - | 25d | 5d 2h |
| Average: | - | 1d 1h | 2h 0min |
| Minimum: | - | 6h 0min | 2h 0min |
| Maximum: | - | 1d 2h | 2h 0min |
| Standard deviation: | - | 1h 10min | 0min 0s |
| Variance: | - | 620d | 0min 0s |
| Quality Gate Pass: New Blocker / Critical / High Issues |
• Quality Gate Description:
An issue with the severity Blocker cannot move to production, it must be fixed.
An issue with a severity level Critical shouldn't move to production. It still can for business imperative needs purposes, but at worth it must be fixed during the next iterations.
An issue with a severity level High should be fixed quickly, but can wait until the next scheduled interval.
The severity of an issue is either defined explicitely in the rule source code, either inferred from the issue annual interest and thresholds defined in the NDepend Project Properties > Issue and Debt.
No issue matched
| Quality Gate Fail: Critical Rules Violated |
• Quality Gate Description:
The concept of critical rule is useful to pinpoint certain rules that should not be violated.
A rule can be made critical just by checking the Critical button in the rule edition control and then saving the rule.
This quality gate fails if any critical rule gets any violations.
When no baseline is available, rules that rely on diff are not counted. If you observe that this quality gate count slightly decreases with no apparent reason, the reason is certainly that rules that rely on diff are not counted because the baseline is not defined.
3 rules matched
| 3 rules | issues | Full Name |
|---|---|---|
| Avoid types too big | 256 issues | Rule |
| Avoid methods too big, too complex | 1 811 issues | Rule |
| Avoid methods with too many parameters | 204 issues | Rule |
Statistics
| Stat | issues |
|---|---|
| Sum: | 2 271 |
| Average: | 757 |
| Minimum: | 204 |
| Maximum: | 1 811 |
| Standard deviation: | 745.59 |
| Variance: | 555 909 |
| Quality Gate Pass: Percentage Debt |
• Quality Gate Description:
% Debt total is defined as a percentage on:
• the estimated total effort to develop the code base
• and the the estimated total time to fix all issues (the Debt)
Estimated total effort to develop the code base is inferred from # lines of code of the code base and from the Estimated number of man-dat to develop 1000 logicial lines of code setting found in NDepend Project Properties > Issue and Debt.
Debt documentation: http://www.ndepend.com/Doc_TechnicalDebt#Debt
This quality gates fails if the estimated debt is more than 30% of the estimated effort to develop the code base, and warns if the estimated debt is more than 20% of the estimated effort to develop the code base
Scalar Result: 10.54 %
| Quality Gate Pass: New Debt since Baseline |
• Quality Gate Description:
This Quality Gate fails if the estimated effort to fix new or worsened issues (what is called the New Debt since Baseline) is higher than 2 man-days.
This Quality Gate warns if this estimated effort is positive.
Debt documentation: http://www.ndepend.com/Doc_TechnicalDebt#Debt
Scalar Result: 0 man-days
| Quality Gate Pass: Debt Rating per Namespace |
• Quality Gate Description:
Forbid namespaces with a poor Debt Rating equals to E or D.
The Debt Rating for a code element is estimated by the value of the Debt Ratio and from the various rating thresholds defined in this project Debt Settings.
The Debt Ratio of a code element is a percentage of Debt Amount (in floating man-days) compared to the estimated effort to develop the code element (also in floating man-days).
The estimated effort to develop the code element is inferred from the code elements number of lines of code, and from the project Debt Settings parameters estimated number of man-days to develop 1000 logical lines of code.
The logical lines of code corresponds to the number of debug breakpoints in a method and doesn't depend on code formatting nor comments.
The Quality Gate can be modified to match assemblies, types or methods with a poor Debt Rating, instead of matching namespaces.
No namespace matched
| Quality Gate Pass: New Annual Interest since Baseline |
• Quality Gate Description:
This Quality Gate fails if the estimated annual cost to leave all issues unfixed, increased from more than 2 man-days since the baseline.
This Quality Gate warns if this estimated annual cost is positive.
This estimated annual cost is named the Annual-Interest.
Each rule can either provide a formula to compute the Annual-Interest per issue, or assign a Severity level for each issue. Some thresholds defined in Project Properties > Issue and Debt > Annual Interest are used to infer an Annual-Interest value from a Severity level. Annual Interest documentation: http://www.ndepend.com/Doc_TechnicalDebt#AnnualInterest
Scalar Result: 0 man-days
| Project Rules | 247253 |
| Code Smells | 063 |
|
 | Critical Rule Violated: Avoid types too big |
• Rule Description:
This rule matches types with more than 200 lines of code. Only lines of code in JustMyCode methods are taken account.
Types where NbLinesOfCode > 200 are extremely complex to develop and maintain. See the definition of the NbLinesOfCode metric here http://www.cppdepend.com/Metrics.aspx#NbLinesOfCode
Maybe you are facing the God Class phenomenon: A God Class is a class that controls way too many other classes in the system and has grown beyond all logic to become The Class That Does Everything.
• How to Fix Issues: Types with many lines of code should be split in a group of smaller types. To refactor a God Class you'll need patience, and you might even need to recreate everything from scratch. Here are a few refactoring advices: • The logic in the God Class must be splitted in smaller classes. These smaller classes can eventually become private classes nested in the original God Class, whose instances objects become composed of instances of smaller nested classes. • Smaller classes partitioning should be driven by the multiple responsibilities handled by the God Class. To identify these responsibilities it often helps to look for subsets of methods strongly coupled with subsets of fields. • If the God Class contains way more logic than states, a good option can be to define one or several static classes that contains no static field but only pure static methods. A pure static method is a function that computes a result only from inputs parameters, it doesn't read nor assign any static or instance field. The main advantage of pure static methods is that they are easily testable. • Try to maintain the interface of the God Class at first and delegate calls to the new extracted classes. In the end the God Class should be a pure facade without its own logic. Then you can keep it for convenience or throw it away and start to use the new classes only. • Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a 200 lines of code type, up to 10 hours for a type with 2.000 or more lines of code. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
• How to Fix Issues: Types with many lines of code should be split in a group of smaller types. To refactor a God Class you'll need patience, and you might even need to recreate everything from scratch. Here are a few refactoring advices: • The logic in the God Class must be splitted in smaller classes. These smaller classes can eventually become private classes nested in the original God Class, whose instances objects become composed of instances of smaller nested classes. • Smaller classes partitioning should be driven by the multiple responsibilities handled by the God Class. To identify these responsibilities it often helps to look for subsets of methods strongly coupled with subsets of fields. • If the God Class contains way more logic than states, a good option can be to define one or several static classes that contains no static field but only pure static methods. A pure static method is a function that computes a result only from inputs parameters, it doesn't read nor assign any static or instance field. The main advantage of pure static methods is that they are easily testable. • Try to maintain the interface of the God Class at first and delegate calls to the new extracted classes. In the end the God Class should be a pure facade without its own logic. Then you can keep it for convenience or throw it away and start to use the new classes only. • Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a 200 lines of code type, up to 10 hours for a type with 2.000 or more lines of code. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
256 types matched
- The following list of types is truncated and contains only the first 100 types of the 256 types matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 256 types | locJustMyCode | Methods | Fields | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|
| idPlayer | 4 581 | 225 methods | 196 fields | 1d 2h | 2h 0min | idPlayer |
| idPlayer | 4 045 | 205 methods | 177 fields | 1d 2h | 2h 0min | idPlayer |
| idAI | 3 949 | 248 methods | 118 fields | 1d 2h | 2h 0min | idAI |
| idCollisionModelManagerLocal | 3 780 | 136 methods | 16 fields | 1d 2h | 2h 0min | idCollisionModelManagerLocal |
| idGameLocal | 3 144 | 163 methods | 97 fields | 1d 2h | 2h 0min | idGameLocal |
| idMatX | 2 918 | 162 methods | 7 fields | 1d 2h | 2h 0min | idMatX |
| idGameLocal | 2 857 | 156 methods | 87 fields | 1d 2h | 2h 0min | idGameLocal |
| idMultiplayerGame | 2 300 | 110 methods | 56 fields | 1d 2h | 2h 0min | idMultiplayerGame |
| idSessionLocal | 2 170 | 97 methods | 81 fields | 1d 2h | 2h 0min | idSessionLocal |
| CMainFrame | 2 107 | 411 methods | 19 fields | 1d 2h | 2h 0min | CMainFrame |
| idSIMD_SSE | 2 099 | 84 methods | no field | 1d 2h | 2h 0min | idSIMD_SSE |
| idRenderWorldLocal | 2 033 | 102 methods | 20 fields | 1d 2h | 2h 0min | idRenderWorldLocal |
| idWindow | 1 968 | 137 methods | 69 fields | 1d 1h | 1h 57min | idWindow |
| idMultiplayerGame | 1 917 | 90 methods | 50 fields | 1d 1h | 1h 54min | idMultiplayerGame |
| idFileSystemLocal | 1 792 | 86 methods | 33 fields | 1d 0h | 1h 46min | idFileSystemLocal |
| idFileSystemLocal | 1 785 | 86 methods | 33 fields | 1d 0h | 1h 45min | idFileSystemLocal |
| idWeapon | 1 780 | 124 methods | 104 fields | 1d 0h | 1h 45min | idWeapon |
| idEntity | 1 743 | 219 methods | 40 fields | 1d 0h | 1h 43min | idEntity |
| idParser | 1 709 | 94 methods | 14 fields | 1d 0h | 1h 40min | idParser |
| idEntity | 1 673 | 211 methods | 35 fields | 1d 0h | 1h 38min | idEntity |
| idSIMD_Generic | 1 563 | 86 methods | no field | 7h 48min | 1h 31min | idSIMD_Generic |
| idFrustum | 1 549 | 73 methods | 7 fields | 7h 44min | 1h 30min | idFrustum |
| CXYWnd | 1 519 | 101 methods | 36 fields | 7h 35min | 1h 28min | CXYWnd |
| idMaterial | 1 446 | 100 methods | 42 fields | 7h 13min | 1h 23min | idMaterial |
| idWeapon | 1 431 | 110 methods | 99 fields | 7h 9min | 1h 22min | idWeapon |
| idAsyncServer | 1 381 | 78 methods | 26 fields | 6h 54min | 1h 19min | idAsyncServer |
| idCompiler | 1 378 | 52 methods | 18 fields | 6h 53min | 1h 19min | idCompiler |
| idCompiler | 1 378 | 52 methods | 18 fields | 6h 53min | 1h 19min | idCompiler |
| idActor | 1 351 | 120 methods | 42 fields | 6h 45min | 1h 17min | idActor |
| idPhysics_AF | 1 341 | 118 methods | 50 fields | 6h 42min | 1h 16min | idPhysics_AF |
| idPhysics_AF | 1 341 | 118 methods | 50 fields | 6h 42min | 1h 16min | idPhysics_AF |
| idActor | 1 320 | 113 methods | 41 fields | 6h 36min | 1h 15min | idActor |
| idAASLocal | 1 275 | 74 methods | 15 fields | 6h 22min | 1h 12min | idAASLocal |
| idAASLocal | 1 275 | 74 methods | 15 fields | 6h 22min | 1h 12min | idAASLocal |
| idImage | 1 253 | 31 methods | 33 fields | 6h 15min | 1h 11min | idImage |
| idInterpreter | 1 244 | 39 methods | 17 fields | 6h 13min | 1h 10min | idInterpreter |
| idInterpreter | 1 244 | 39 methods | 17 fields | 6h 13min | 1h 10min | idInterpreter |
| idAsyncClient | 1 232 | 67 methods | 50 fields | 6h 9min | 1h 9min | idAsyncClient |
| codec | 1 186 | 26 methods | 26 fields | 5h 55min | 1h 6min | codec |
| idRenderModelStatic | 1 113 | 54 methods | 18 fields | 5h 33min | 1h 1min | idRenderModelStatic |
| rvGEWorkspace | 1 055 | 84 methods | 26 fields | 5h 16min | 58min | rvGEWorkspace |
| idAASBuild | 1 021 | 46 methods | 9 fields | 5h 6min | 55min | idAASBuild |
| idSoundWorldLocal | 1 004 | 39 methods | 22 fields | 5h 1min | 54min | idSoundWorldLocal |
| idStr | 963 | 136 methods | 4 fields | 4h 48min | 52min | idStr |
| idTraceModel | 947 | 35 methods | 10 fields | 4h 44min | 50min | idTraceModel |
| CSyntaxRichEditCtrl | 899 | 64 methods | 34 fields | 4h 29min | 47min | CSyntaxRichEditCtrl |
| idLexer | 865 | 56 methods | 22 fields | 4h 19min | 45min | idLexer |
| CDialogParticleEditor | 855 | 77 methods | 69 fields | 4h 16min | 44min | CDialogParticleEditor |
| MaterialTreeView | 854 | 67 methods | 15 fields | 4h 16min | 44min | MaterialTreeView |
| idPhysics_Player | 842 | 66 methods | 24 fields | 4h 12min | 44min | idPhysics_Player |
| idPhysics_Player | 842 | 66 methods | 24 fields | 4h 12min | 44min | idPhysics_Player |
| idDeclAF | 833 | 37 methods | 20 fields | 4h 9min | 43min | idDeclAF |
| idWinding | 804 | 46 methods | 3 fields | 4h 1min | 41min | idWinding |
| idAASFileLocal | 780 | 40 methods | no field | 3h 54min | 40min | idAASFileLocal |
| idBrushBSP | 770 | 43 methods | 19 fields | 3h 51min | 39min | idBrushBSP |
| CEntityDlg | 757 | 68 methods | 38 fields | 3h 47min | 38min | CEntityDlg |
| idAnimator | 744 | 63 methods | 17 fields | 3h 43min | 37min | idAnimator |
| idAnimator | 744 | 63 methods | 17 fields | 3h 43min | 37min | idAnimator |
| idBrittleFracture | 739 | 30 methods | 22 fields | 3h 41min | 37min | idBrittleFracture |
| idCommonLocal | 735 | 55 methods | 14 fields | 3h 40min | 37min | idCommonLocal |
| rvGEApp | 722 | 27 methods | 14 fields | 3h 36min | 36min | rvGEApp |
| CCamWnd | 715 | 65 methods | 25 fields | 3h 34min | 35min | CCamWnd |
| idBrittleFracture | 698 | 30 methods | 21 fields | 3h 29min | 34min | idBrittleFracture |
| idCinematicLocal | 688 | 24 methods | 39 fields | 3h 26min | 33min | idCinematicLocal |
| idProjectile | 686 | 35 methods | 20 fields | 3h 25min | 33min | idProjectile |
| idAF | 662 | 35 methods | 14 fields | 3h 18min | 32min | idAF |
| DialogAFBody | 662 | 79 methods | 35 fields | 3h 18min | 32min | DialogAFBody |
| idAF | 662 | 35 methods | 14 fields | 3h 18min | 32min | idAF |
| idMat6 | 658 | 36 methods | 1 field | 3h 17min | 32min | idMat6 |
| idMover | 641 | 65 methods | 22 fields | 3h 12min | 30min | idMover |
| idMover | 641 | 65 methods | 22 fields | 3h 12min | 30min | idMover |
| idProjectile | 635 | 30 methods | 19 fields | 3h 10min | 30min | idProjectile |
| idSurface | 629 | 26 methods | 4 fields | 3h 8min | 30min | idSurface |
| idAnim | 624 | 20 methods | 8 fields | 3h 7min | 29min | idAnim |
| idDeviceContext | 623 | 42 methods | 29 fields | 3h 6min | 29min | idDeviceContext |
| idGameEdit | 608 | 56 methods | no field | 3h 2min | 28min | idGameEdit |
| idGameEdit | 608 | 56 methods | no field | 3h 2min | 28min | idGameEdit |
| idPVS | 608 | 34 methods | 12 fields | 3h 2min | 28min | idPVS |
| idPVS | 596 | 33 methods | 12 fields | 2h 58min | 27min | idPVS |
| idAnim | 568 | 20 methods | 8 fields | 2h 50min | 26min | idAnim |
| CDIB | 563 | 56 methods | 16 fields | 2h 48min | 25min | CDIB |
| idInventory | 557 | 25 methods | 36 fields | 2h 47min | 25min | idInventory |
| idMayaExport | 553 | 26 methods | 2 fields | 2h 45min | 25min | idMayaExport |
| idGameSSDWindow | 548 | 48 methods | 19 fields | 2h 44min | 24min | idGameSSDWindow |
| idSoundSystemLocal | 539 | 28 methods | 70 fields | 2h 41min | 24min | idSoundSystemLocal |
| idPhysics_RigidBody | 538 | 66 methods | 21 fields | 2h 41min | 24min | idPhysics_RigidBody |
| idPhysics_RigidBody | 538 | 66 methods | 21 fields | 2h 41min | 24min | idPhysics_RigidBody |
| idTypeInfoGen | 522 | 15 methods | 7 fields | 2h 36min | 23min | idTypeInfoGen |
| idMD5Anim | 522 | 23 methods | 12 fields | 2h 36min | 23min | idMD5Anim |
| idMD5Anim | 522 | 23 methods | 12 fields | 2h 36min | 23min | idMD5Anim |
| idClip | 520 | 30 methods | 12 fields | 2h 36min | 22min | idClip |
| idClip | 520 | 30 methods | 12 fields | 2h 36min | 22min | idClip |
| idRenderSystemLocal | 518 | 41 methods | 35 fields | 2h 35min | 22min | idRenderSystemLocal |
| idAnimBlend | 505 | 41 methods | 15 fields | 2h 31min | 21min | idAnimBlend |
| idAnimBlend | 505 | 41 methods | 15 fields | 2h 31min | 21min | idAnimBlend |
| CDialogSound | 504 | 52 methods | 25 fields | 2h 31min | 21min | CDialogSound |
| idThread | 497 | 139 methods | 16 fields | 2h 29min | 21min | idThread |
| CDialogTextures | 490 | 38 methods | 19 fields | 2h 27min | 21min | CDialogTextures |
| idAASReach | 487 | 12 methods | 5 fields | 2h 26min | 20min | idAASReach |
| CDialogColorPicker | 483 | 40 methods | 38 fields | 2h 24min | 20min | CDialogColorPicker |
 | Rule Violated: Avoid types with too many methods |
• Rule Description:
This rule matches types with more than 20 methods. Such type might be hard to understand and maintain.
Notice that methods like constructors or property and event accessors are not taken account.
Having many methods for a type might be a symptom of too many responsibilities implemented.
Maybe you are facing the God Class phenomenon: A God Class is a class that controls way too many other classes in the system and has grown beyond all logic to become The Class That Does Everything.
• How to Fix Issues: To refactor properly a God Class please read HowToFix advices from the default rule Types to Big. // The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 20 methods, up to 10 hours for a type with 200 or more methods. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
• How to Fix Issues: To refactor properly a God Class please read HowToFix advices from the default rule Types to Big. // The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 20 methods, up to 10 hours for a type with 200 or more methods. In Debt and Interest computation, this rule takes account of the fact that static types with no mutable fields are just a collection of static methods that can be easily splitted and moved from one type to another.
255 types matched
- The following list of types is truncated and contains only the first 100 types of the 255 types matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 255 types | nbMethods | instanceMethods | staticMethods | # lines of code (LOC) | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|
| CMainFrame | 410 | 407 methods | 3 methods | 2 107 | 1d 2h | 2h 0min | CMainFrame |
| idAI | 247 | 240 methods | 7 methods | 3 949 | 1d 2h | 2h 0min | idAI |
| idAI | 235 | 228 methods | 7 methods | 230 | 1d 2h | 2h 0min | idAI |
| idPlayer | 224 | 223 methods | 1 method | 4 581 | 1d 2h | 2h 0min | idPlayer |
| idEntity | 218 | 216 methods | 2 methods | 1 743 | 1d 2h | 2h 0min | idEntity |
| idEntity | 210 | 208 methods | 2 methods | 1 673 | 1d 2h | 2h 0min | idEntity |
| idPlayer | 204 | 203 methods | 1 method | 4 045 | 1d 2h | 2h 0min | idPlayer |
| idMatX | 162 | 161 methods | 1 method | 2 918 | 1d 0h | 1h 35min | idMatX |
| idGameLocal | 160 | 156 methods | 4 methods | 3 144 | 1d 0h | 1h 33min | idGameLocal |
| idGameLocal | 153 | 149 methods | 4 methods | 2 857 | 7h 39min | 1h 29min | idGameLocal |
| idThread | 138 | 121 methods | 17 methods | 497 | 6h 54min | 1h 19min | idThread |
| idStr | 136 | 90 methods | 46 methods | 963 | 6h 48min | 1h 18min | idStr |
| idWindow | 136 | 136 methods | no method | 1 968 | 6h 48min | 1h 18min | idWindow |
| idThread | 133 | 116 methods | 17 methods | 482 | 6h 39min | 1h 16min | idThread |
| idCollisionModelManagerLocal | 133 | 133 methods | no method | 3 780 | 6h 39min | 1h 16min | idCollisionModelManagerLocal |
| idWeapon | 123 | 118 methods | 5 methods | 1 780 | 6h 9min | 1h 9min | idWeapon |
| idActor | 119 | 118 methods | 1 method | 1 351 | 5h 57min | 1h 6min | idActor |
| idPhysics_AF | 117 | 116 methods | 1 method | 1 341 | 5h 51min | 1h 5min | idPhysics_AF |
| idPhysics_AF | 117 | 116 methods | 1 method | 1 341 | 5h 51min | 1h 5min | idPhysics_AF |
| idActor | 112 | 111 methods | 1 method | 1 320 | 5h 36min | 1h 2min | idActor |
| idWeapon | 109 | 104 methods | 5 methods | 1 431 | 5h 27min | 1h 0min | idWeapon |
| idMultiplayerGame | 107 | 100 methods | 7 methods | 2 300 | 5h 21min | 59min | idMultiplayerGame |
| idRenderWorldLocal | 101 | 101 methods | no method | 2 033 | 5h 3min | 55min | idRenderWorldLocal |
| CXYWnd | 100 | 96 methods | 4 methods | 1 519 | 5h 0min | 54min | CXYWnd |
| idMaterial | 99 | 99 methods | no method | 1 446 | 4h 57min | 53min | idMaterial |
| idSessionLocal | 96 | 96 methods | no method | 2 170 | 4h 48min | 51min | idSessionLocal |
| idParser | 94 | 86 methods | 8 methods | 1 709 | 4h 42min | 50min | idParser |
| idMultiplayerGame | 87 | 80 methods | 7 methods | 1 917 | 4h 21min | 45min | idMultiplayerGame |
| idBitMsg | 84 | 82 methods | 2 methods | 366 | 4h 12min | 43min | idBitMsg |
| rvGEWorkspace | 84 | 80 methods | 4 methods | 1 055 | 4h 12min | 43min | rvGEWorkspace |
| idSIMDProcessor | 83 | 83 methods | no method | 1 | 4h 9min | 43min | idSIMDProcessor |
| idSIMD_Generic | 83 | 83 methods | no method | 1 563 | 4h 9min | 43min | idSIMD_Generic |
| idFileSystemLocal | 83 | 76 methods | 7 methods | 1 792 | 4h 9min | 43min | idFileSystemLocal |
| idFileSystemLocal | 83 | 76 methods | 7 methods | 1 785 | 4h 9min | 43min | idFileSystemLocal |
| idSIMD_SSE | 81 | 81 methods | no method | 2 099 | 4h 3min | 41min | idSIMD_SSE |
| DialogAFBody | 78 | 75 methods | 3 methods | 662 | 3h 54min | 40min | DialogAFBody |
| CDialogParticleEditor | 76 | 73 methods | 3 methods | 855 | 3h 48min | 38min | CDialogParticleEditor |
| idAsyncServer | 75 | 75 methods | no method | 1 381 | 3h 45min | 38min | idAsyncServer |
| idPhysics_Base | 74 | 73 methods | 1 method | 169 | 3h 42min | 37min | idPhysics_Base |
| idPhysics_Base | 74 | 73 methods | 1 method | 169 | 3h 42min | 37min | idPhysics_Base |
| idAASLocal | 73 | 73 methods | no method | 1 275 | 3h 39min | 36min | idAASLocal |
| idAASLocal | 73 | 73 methods | no method | 1 275 | 3h 39min | 36min | idAASLocal |
| idMath | 72 | no method | 72 methods | 349 | 3h 36min | 36min | idMath |
| idFrustum | 71 | 71 methods | no method | 1 549 | 3h 33min | 35min | idFrustum |
| idPhysics | 71 | 69 methods | 2 methods | 5 | 3h 33min | 35min | idPhysics |
| idPhysics | 71 | 69 methods | 2 methods | 5 | 3h 33min | 35min | idPhysics |
| idPhysics_StaticMulti | 70 | 69 methods | 1 method | 335 | 3h 30min | 34min | idPhysics_StaticMulti |
| idPhysics_StaticMulti | 70 | 69 methods | 1 method | 335 | 3h 30min | 34min | idPhysics_StaticMulti |
| idPhysics_Static | 69 | 68 methods | 1 method | 203 | 3h 27min | 34min | idPhysics_Static |
| idPhysics_Static | 69 | 68 methods | 1 method | 203 | 3h 27min | 34min | idPhysics_Static |
| CEntityDlg | 67 | 57 methods | 10 methods | 757 | 3h 21min | 32min | CEntityDlg |
| MaterialTreeView | 66 | 62 methods | 4 methods | 854 | 3h 18min | 32min | MaterialTreeView |
| idPhysics_RigidBody | 65 | 64 methods | 1 method | 538 | 3h 15min | 31min | idPhysics_RigidBody |
| idPhysics_RigidBody | 65 | 64 methods | 1 method | 538 | 3h 15min | 31min | idPhysics_RigidBody |
| idAsyncClient | 64 | 63 methods | 1 method | 1 232 | 3h 12min | 30min | idAsyncClient |
| CCamWnd | 64 | 60 methods | 4 methods | 715 | 3h 12min | 30min | CCamWnd |
| idPhysics_Player | 63 | 62 methods | 1 method | 842 | 3h 9min | 30min | idPhysics_Player |
| CSyntaxRichEditCtrl | 63 | 62 methods | 1 method | 899 | 3h 9min | 30min | CSyntaxRichEditCtrl |
| idPhysics_Player | 63 | 62 methods | 1 method | 842 | 3h 9min | 30min | idPhysics_Player |
| idAnimator | 62 | 62 methods | no method | 744 | 3h 6min | 29min | idAnimator |
| idPhysics_Parametric | 62 | 61 methods | 1 method | 422 | 3h 6min | 29min | idPhysics_Parametric |
| idMover | 62 | 61 methods | 1 method | 641 | 3h 6min | 29min | idMover |
| idAnimator | 62 | 62 methods | no method | 744 | 3h 6min | 29min | idAnimator |
| idPhysics_Parametric | 62 | 61 methods | 1 method | 422 | 3h 6min | 29min | idPhysics_Parametric |
| idMover | 62 | 61 methods | 1 method | 641 | 3h 6min | 29min | idMover |
| idClass | 59 | 49 methods | 10 methods | 268 | 2h 57min | 27min | idClass |
| DialogAFConstraintUniversal | 59 | 56 methods | 3 methods | 397 | 2h 57min | 27min | DialogAFConstraintUniversal |
| idClass | 59 | 49 methods | 10 methods | 272 | 2h 57min | 27min | idClass |
| idLexer | 56 | 55 methods | 1 method | 865 | 2h 48min | 25min | idLexer |
| CDIB | 56 | 55 methods | 1 method | 563 | 2h 48min | 25min | CDIB |
| idDict | 55 | 50 methods | 5 methods | 311 | 2h 45min | 24min | idDict |
| idGameEdit | 55 | 55 methods | no method | 608 | 2h 45min | 24min | idGameEdit |
| idGameEdit | 55 | 55 methods | no method | 608 | 2h 45min | 24min | idGameEdit |
| idLight | 53 | 52 methods | 1 method | 382 | 2h 39min | 23min | idLight |
| idRenderModelStatic | 53 | 52 methods | 1 method | 1 113 | 2h 39min | 23min | idRenderModelStatic |
| idLight | 53 | 52 methods | 1 method | 384 | 2h 39min | 23min | idLight |
| idBitMsgDelta | 52 | 52 methods | no method | 285 | 2h 36min | 22min | idBitMsgDelta |
| idCommonLocal | 52 | 52 methods | no method | 735 | 2h 36min | 22min | idCommonLocal |
| MaterialDocManager | 52 | 52 methods | no method | 301 | 2h 36min | 22min | MaterialDocManager |
| idMat3 | 51 | 51 methods | no method | 336 | 2h 33min | 22min | idMat3 |
| idVec3 | 51 | 51 methods | no method | 320 | 2h 33min | 22min | idVec3 |
| DialogAFConstraintBallAndSocket | 51 | 48 methods | 3 methods | 327 | 2h 33min | 22min | DialogAFConstraintBallAndSocket |
| CPropTree | 51 | 44 methods | 7 methods | 355 | 2h 33min | 22min | CPropTree |
| idCompiler | 50 | 50 methods | no method | 1 378 | 2h 30min | 21min | idCompiler |
| idCompiler | 50 | 50 methods | no method | 1 378 | 2h 30min | 21min | idCompiler |
| DialogAFConstraintSpring | 49 | 46 methods | 3 methods | 273 | 2h 27min | 21min | DialogAFConstraintSpring |
| CDialogSound | 49 | 48 methods | 1 method | 504 | 2h 27min | 21min | CDialogSound |
| MEMainFrame | 48 | 45 methods | 3 methods | 355 | 2h 24min | 20min | MEMainFrame |
| idBounds | 47 | 47 methods | no method | 292 | 2h 21min | 19min | idBounds |
| idClipModel | 47 | 38 methods | 9 methods | 263 | 2h 21min | 19min | idClipModel |
| CVectorCtl | 47 | 46 methods | 1 method | 228 | 2h 21min | 19min | CVectorCtl |
| idGameSSDWindow | 47 | 47 methods | no method | 548 | 2h 21min | 19min | idGameSSDWindow |
| idUserInterfaceLocal | 47 | 47 methods | no method | 241 | 2h 21min | 19min | idUserInterfaceLocal |
| idClipModel | 47 | 38 methods | 9 methods | 263 | 2h 21min | 19min | idClipModel |
| idWinding | 46 | 45 methods | 1 method | 804 | 2h 18min | 19min | idWinding |
| idRestoreGame | 46 | 46 methods | no method | 292 | 2h 18min | 19min | idRestoreGame |
| idAASBuild | 46 | 46 methods | no method | 1 021 | 2h 18min | 19min | idAASBuild |
| idRestoreGame | 46 | 46 methods | no method | 294 | 2h 18min | 19min | idRestoreGame |
| idProgram | 45 | 45 methods | no method | 468 | 2h 15min | 18min | idProgram |
| idProgram | 45 | 45 methods | no method | 468 | 2h 15min | 18min | idProgram |
| Rule Violated: Avoid types with too many fields |
• Rule Description:
This rule matches types with more than 15 fields. Such type might be hard to understand and maintain.
Notice that constant fields and static-readonly fields are not counted. Enumerations types are not counted also.
Having many fields for a type might be a symptom of too many responsibilities implemented.
• How to Fix Issues: To refactor such type and increase code quality and maintainability, certainly you'll have to group subsets of fields into smaller types and dispatch the logic implemented into the methods into these smaller types. More refactoring advices can be found in the default rule Types to Big, HowToFix section. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 15 fields, to up to 10 hours for a type with 200 or more fields.
• How to Fix Issues: To refactor such type and increase code quality and maintainability, certainly you'll have to group subsets of fields into smaller types and dispatch the logic implemented into the methods into these smaller types. More refactoring advices can be found in the default rule Types to Big, HowToFix section. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a type with 15 fields, to up to 10 hours for a type with 200 or more fields.
164 types matched
- The following list of types is truncated and contains only the first 100 types of the 164 types matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 164 types | instanceFields | staticFields | methodsAssigningFields | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|
| idPlayer | 191 fields | no field | 496 methods | 1d 1h | 1h 54min | idPlayer |
| idPlayer | 172 fields | no field | 438 methods | 1d 0h | 1h 42min | idPlayer |
| idAI | 116 fields | no field | 200 methods | 5h 54min | 1h 6min | idAI |
| idAI | 113 fields | no field | 1 method | 5h 46min | 1h 4min | idAI |
| idWeapon | 102 fields | no field | 201 methods | 5h 13min | 57min | idWeapon |
| idWeapon | 97 fields | no field | 186 methods | 4h 59min | 54min | idWeapon |
| idGameLocal | 95 fields | no field | 495 methods | 4h 53min | 53min | idGameLocal |
| idGameLocal | 84 fields | no field | 435 methods | 4h 21min | 46min | idGameLocal |
| jpeg_decompress_struct | 84 fields | no field | 169 methods | 4h 21min | 46min | jpeg_decompress_struct |
| CDialogParticleEditor | 68 fields | no field | 82 methods | 3h 34min | 35min | CDialogParticleEditor |
| idSessionLocal | 66 fields | no field | 163 methods | 3h 28min | 34min | idSessionLocal |
| idWindow | 63 fields | no field | 192 methods | 3h 20min | 32min | idWindow |
| CPrefsDlg | 61 fields | no field | 112 methods | 3h 14min | 31min | CPrefsDlg |
| jpeg_compress_struct | 60 fields | no field | 149 methods | 3h 11min | 30min | jpeg_compress_struct |
| idAsyncClient | 50 fields | no field | 109 methods | 2h 42min | 24min | idAsyncClient |
| idMultiplayerGame | 50 fields | no field | 139 methods | 2h 42min | 24min | idMultiplayerGame |
| roqParam | 49 fields | no field | 48 methods | 2h 39min | 23min | roqParam |
| idPhysics_AF | 48 fields | no field | 155 methods | 2h 36min | 23min | idPhysics_AF |
| idPhysics_AF | 48 fields | no field | 155 methods | 2h 36min | 23min | idPhysics_AF |
| idMultiplayerGame | 44 fields | no field | 116 methods | 2h 24min | 20min | idMultiplayerGame |
| QEGlobals_t | 44 fields | no field | 131 methods | 2h 24min | 20min | QEGlobals_t |
| glconfig_s | 43 fields | no field | 58 methods | 2h 21min | 19min | glconfig_s |
| CLightDlg | 43 fields | no field | 69 methods | 2h 21min | 19min | CLightDlg |
| idMaterial | 42 fields | no field | 90 methods | 2h 18min | 19min | idMaterial |
| idAFBody | 41 fields | no field | 64 methods | 2h 15min | 18min | idAFBody |
| idAFBody | 41 fields | no field | 64 methods | 2h 15min | 18min | idAFBody |
| idActor | 40 fields | no field | 115 methods | 2h 12min | 17min | idActor |
| idActor | 39 fields | no field | 102 methods | 2h 10min | 17min | idActor |
| cm_traceWork_s | 39 fields | no field | 86 methods | 2h 10min | 17min | cm_traceWork_s |
| idCinematicLocal | 39 fields | no field | 77 methods | 2h 10min | 17min | idCinematicLocal |
| CDialogColorPicker | 38 fields | no field | 33 methods | 2h 7min | 16min | CDialogColorPicker |
| ve_setup_data_template | 37 fields | no field | no method | 2h 4min | 16min | ve_setup_data_template |
| CEntityDlg | 37 fields | no field | 17 methods | 2h 4min | 16min | CEntityDlg |
| idEntity | 37 fields | no field | 368 methods | 2h 4min | 16min | idEntity |
| idParticleStage | 36 fields | no field | 138 methods | 2h 1min | 15min | idParticleStage |
| idImageManager | 36 fields | no field | 46 methods | 2h 1min | 15min | idImageManager |
| Win32Vars_t | 36 fields | no field | 54 methods | 2h 1min | 15min | Win32Vars_t |
| idInventory | 36 fields | no field | 115 methods | 2h 1min | 15min | idInventory |
| idInventory | 35 fields | no field | 114 methods | 1h 58min | 14min | idInventory |
| idRenderSystemLocal | 35 fields | no field | 74 methods | 1h 58min | 14min | idRenderSystemLocal |
| CXYWnd | 35 fields | no field | 32 methods | 1h 58min | 14min | CXYWnd |
| CSyntaxRichEditCtrl | 34 fields | no field | 71 methods | 1h 55min | 14min | CSyntaxRichEditCtrl |
| DialogAFBody | 33 fields | no field | 69 methods | 1h 52min | 13min | DialogAFBody |
| idEntity | 32 fields | no field | 315 methods | 1h 49min | 12min | idEntity |
| idIK_Walk | 32 fields | no field | 61 methods | 1h 49min | 12min | idIK_Walk |
| idImage | 32 fields | no field | 119 methods | 1h 49min | 12min | idImage |
| CVectorCtl | 32 fields | no field | 45 methods | 1h 49min | 12min | CVectorCtl |
| idIK_Walk | 32 fields | no field | 61 methods | 1h 49min | 12min | idIK_Walk |
| idFXSingleAction | 31 fields | no field | 24 methods | 1h 46min | 12min | idFXSingleAction |
| idSimpleWindow | 30 fields | no field | 34 methods | 1h 43min | 11min | idSimpleWindow |
| cm_model_s | 28 fields | no field | 113 methods | 1h 37min | 10min | cm_model_s |
| idSoundSystemLocal | 28 fields | no field | 55 methods | 1h 37min | 10min | idSoundSystemLocal |
| idExportOptions | 28 fields | no field | 40 methods | 1h 37min | 10min | idExportOptions |
| idMover_Binary | 27 fields | no field | 73 methods | 1h 35min | 9min | idMover_Binary |
| idMover_Binary | 26 fields | no field | 72 methods | 1h 32min | 9min | idMover_Binary |
| idMsgChannel | 26 fields | no field | 54 methods | 1h 32min | 9min | idMsgChannel |
| performanceCounters_t | 26 fields | no field | 2 methods | 1h 32min | 9min | performanceCounters_t |
| st_lwSurface | 26 fields | no field | 14 methods | 1h 32min | 9min | st_lwSurface |
| codec | 26 fields | no field | 86 methods | 1h 32min | 9min | codec |
| CSurfaceDlg | 26 fields | no field | 28 methods | 1h 32min | 9min | CSurfaceDlg |
| idGameBustOutWindow | 26 fields | no field | 50 methods | 1h 32min | 9min | idGameBustOutWindow |
| idAsyncServer | 25 fields | no field | 54 methods | 1h 29min | 8min | idAsyncServer |
| viewDef_s | 25 fields | no field | 64 methods | 1h 29min | 8min | viewDef_s |
| bitrate_manager_state | 25 fields | no field | 18 methods | 1h 29min | 8min | bitrate_manager_state |
| WinConData | 25 fields | no field | 20 methods | 1h 29min | 8min | WinConData |
| dmapGlobals_t | 25 fields | no field | 52 methods | 1h 29min | 8min | dmapGlobals_t |
| rvGEWorkspace | 25 fields | no field | 51 methods | 1h 29min | 8min | rvGEWorkspace |
| CDialogSound | 25 fields | no field | 40 methods | 1h 29min | 8min | CDialogSound |
| idGameBearShootWindow | 25 fields | no field | 50 methods | 1h 29min | 8min | idGameBearShootWindow |
| DialogAFView | 24 fields | no field | 24 methods | 1h 26min | 7min | DialogAFView |
| CCamWnd | 24 fields | no field | 25 methods | 1h 26min | 7min | CCamWnd |
| CLightInfo | 24 fields | no field | 41 methods | 1h 26min | 7min | CLightInfo |
| idRenderLightLocal | 23 fields | no field | 55 methods | 1h 23min | 7min | idRenderLightLocal |
| vorbis_info_psy | 23 fields | no field | 29 methods | 1h 23min | 7min | vorbis_info_psy |
| OggVorbis_File | 23 fields | no field | 90 methods | 1h 23min | 7min | OggVorbis_File |
| idPlayerView | 23 fields | no field | 34 methods | 1h 23min | 7min | idPlayerView |
| idFileSystemLocal | 22 fields | no field | 62 methods | 1h 20min | 6min | idFileSystemLocal |
| idPhysics_Player | 22 fields | no field | 52 methods | 1h 20min | 6min | idPhysics_Player |
| idPlayerView | 22 fields | no field | 34 methods | 1h 20min | 6min | idPlayerView |
| _CURL_CONTEXT | 22 fields | no field | 38 methods | 1h 20min | 6min | _CURL_CONTEXT |
| idFileSystemLocal | 22 fields | no field | 62 methods | 1h 20min | 6min | idFileSystemLocal |
| idSoundWorldLocal | 22 fields | no field | 53 methods | 1h 20min | 6min | idSoundWorldLocal |
| DialogAFConstraintUniversal | 22 fields | no field | 44 methods | 1h 20min | 6min | DialogAFConstraintUniversal |
| DialogAFProperties | 22 fields | no field | 57 methods | 1h 20min | 6min | DialogAFProperties |
| idAASSettings | 22 fields | no field | 29 methods | 1h 20min | 6min | idAASSettings |
| idPhysics_Player | 22 fields | no field | 52 methods | 1h 20min | 6min | idPhysics_Player |
| idLexer | 21 fields | no field | 109 methods | 1h 17min | 5min | idLexer |
| idDeclAF_Body | 21 fields | no field | 39 methods | 1h 17min | 5min | idDeclAF_Body |
| serverClient_s | 21 fields | no field | 63 methods | 1h 17min | 5min | serverClient_s |
| jpeg_component_info | 21 fields | no field | 97 methods | 1h 17min | 5min | jpeg_component_info |
| vorbis_block | 21 fields | no field | 52 methods | 1h 17min | 5min | vorbis_block |
| codec_setup_info | 21 fields | no field | 58 methods | 1h 17min | 5min | codec_setup_info |
| SSDEntity | 21 fields | no field | 57 methods | 1h 17min | 5min | SSDEntity |
| idExportJoint | 21 fields | no field | 34 methods | 1h 17min | 5min | idExportJoint |
| idLCP_Symmetric | 20 fields | no field | 23 methods | 1h 14min | 5min | idLCP_Symmetric |
| idAFConstraint | 20 fields | no field | 114 methods | 1h 14min | 5min | idAFConstraint |
| idProgram | 20 fields | no field | 48 methods | 1h 14min | 5min | idProgram |
| idMover | 20 fields | no field | 59 methods | 1h 14min | 5min | idMover |
| idConsoleLocal | 20 fields | no field | 41 methods | 1h 14min | 5min | idConsoleLocal |
| idDeclAF | 20 fields | no field | 63 methods | 1h 14min | 5min | idDeclAF |
| Critical Rule Violated: Avoid methods too big, too complex |
• Rule Description:
This rule matches methods where ILNestingDepth > 2 and (NbLinesOfCode > 35 or CyclomaticComplexity > 20 Such method is typically hard to understand and maintain.
Maybe you are facing the God Method phenomenon. A "God Method" is a method that does way too many processes in the system and has grown beyond all logic to become The Method That Does Everything. When need for new processes increases suddenly some programmers realize: why should I create a new method for each processe if I can only add an if.
See the definition of the CyclomaticComplexity metric here: http://www.cppdepend.com/Metrics.aspx#CC
• How to Fix Issues: A large and complex method should be split in smaller methods, or even one or several classes can be created for that. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). Large switch…case structures might be refactored through the help of a set of types that implement a common interface, the interface polymorphism playing the role of the switch cases tests. Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. The estimated Debt, which means the effort to fix such issue, varies from 40 minutes to 8 hours, linearly from a weighted complexity score.
• How to Fix Issues: A large and complex method should be split in smaller methods, or even one or several classes can be created for that. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). Large switch…case structures might be refactored through the help of a set of types that implement a common interface, the interface polymorphism playing the role of the switch cases tests. Unit Tests can help: write tests for each method before extracting it to ensure you don't break functionality. The estimated Debt, which means the effort to fix such issue, varies from 40 minutes to 8 hours, linearly from a weighted complexity score.
1,811 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 1811 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 811 methods | # lines of code (LOC) | Cyclomatic Complexity (CC) | complexityScore | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|
| Execute() | 715 | 193 | 550 | 1d 0h | 40min | idInterpreter.Execute() |
| Execute() | 715 | 193 | 550 | 1d 0h | 40min | idInterpreter.Execute() |
| Curl_readwrite(structconnectdata*,bool*) | 460 | 186 | 416 | 1d 0h | 40min | __Globals.Curl_readwrite (structconnectdata*,bool*) |
| Curl_setopt(structSessionHandle* ,CURLoption) | 436 | 170 | 388 | 7h 45min | 40min | __Globals.Curl_setopt (structSessionHandle*,CURLoption) |
| GLimp_EnableLogging(bool) | 706 | 10 | 363 | 7h 16min | 40min | __Globals.GLimp_EnableLogging(bool) |
| CreateConnection(structSessionHandle* ,structconnectdata** ,structCurl_dns_entry**,bool*) | 413 | 142 | 348 | 6h 58min | 40min | __Globals.CreateConnection (structSessionHandle* ,structconnectdata** ,structCurl_dns_entry**,bool*) |
| ParseStage(idLexer&,consttextureRepeat_t ) | 349 | 150 | 324 | 6h 29min | 40min | idMaterial.ParseStage(idLexer& ,consttextureRepeat_t) |
| Curl_gd_parse(void*) | 402 | 108 | 309 | 6h 11min | 40min | __Globals.Curl_gd_parse(void*) |
| EvaluateTokens(idToken*,long*,double* ,int) | 345 | 129 | 301 | 6h 2min | 40min | idParser.EvaluateTokens(idToken*,long* ,double*,int) |
| Test() | 432 | 82 | 298 | 5h 58min | 40min | idMatX.Test() |
| HandleMainMenuCommands(constchar*) | 296 | 140 | 288 | 5h 46min | 40min | idSessionLocal.HandleMainMenuCommands (constchar*) |
| AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) | 320 | 128 | 288 | 5h 46min | 40min | idAnim.AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) |
| Curl_http(structconnectdata*) | 265 | 141 | 273 | 5h 28min | 40min | __Globals.Curl_http(structconnectdata*) |
| AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) | 279 | 113 | 252 | 5h 4min | 40min | idAnim.AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) |
| TestMath() | 325 | 65 | 227 | 4h 34min | 40min | __Globals.TestMath() |
| Curl_cookie_add(structSessionHandle* ,structCookieInfo*,bool,char*,char* ,char*) | 232 | 103 | 219 | 4h 24min | 40min | __Globals.Curl_cookie_add (structSessionHandle*,structCookieInfo* ,bool,char*,char*,char*) |
| dprintf_formatf(void*,int(*)(int,FILE*) ,constchar*,va_list) | 238 | 99 | 218 | 4h 23min | 40min | __Globals.dprintf_formatf(void*,int(*) (int,FILE*),constchar*,va_list) |
| ParseScope(constchar*,bool,idParser& ,idClassTypeInfo*) | 234 | 97 | 214 | 4h 18min | 40min | idTypeInfoGen.ParseScope(constchar*,bool ,idParser&,idClassTypeInfo*) |
| Reachability_Step_Barrier_WaterJump_Walk OffLedge(int,int) | 270 | 78 | 213 | 4h 17min | 40min | idAASReach .Reachability_Step_Barrier_WaterJump_Wal kOffLedge(int,int) |
| HessenbergToRealSchur(idMatX&,idVecX& ,idVecX&) | 260 | 73 | 203 | 4h 5min | 40min | idMatX.HessenbergToRealSchur(idMatX& ,idVecX&,idVecX&) |
| lwGetSurface5(idFile*,int,lwObject*) | 234 | 79 | 196 | 3h 57min | 39min | __Globals.lwGetSurface5(idFile*,int ,lwObject*) |
| HandleCommand(WPARAM,LPARAM) | 248 | 72 | 196 | 3h 57min | 39min | rvGEApp.HandleCommand(WPARAM,LPARAM) |
| FormAdd(structcurl_httppost** ,structcurl_httppost**,va_list) | 201 | 94 | 194 | 3h 55min | 38min | __Globals.FormAdd(structcurl_httppost** ,structcurl_httppost**,va_list) |
| HandleInitMenu(WPARAM,LPARAM) | 173 | 105 | 191 | 3h 51min | 37min | rvGEApp.HandleInitMenu(WPARAM,LPARAM) |
| ParseMaterial(idLexer&) | 192 | 92 | 188 | 3h 47min | 37min | idMaterial.ParseMaterial(idLexer&) |
| dradbg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 270 | 52 | 187 | 3h 46min | 37min | __Globals.dradbg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| QGL_Init(constchar*) | 368 | 2 | 186 | 3h 45min | 36min | __Globals.QGL_Init(constchar*) |
| QGL_Shutdown() | 362 | 2 | 183 | 3h 41min | 36min | __Globals.QGL_Shutdown() |
| HandleEvent(constsysEvent_t*,bool*) | 164 | 96 | 178 | 3h 36min | 35min | idWindow.HandleEvent(constsysEvent_t* ,bool*) |
| CallFrameCommands(idEntity*,int,int) | 208 | 74 | 178 | 3h 36min | 35min | idAnim.CallFrameCommands(idEntity*,int ,int) |
| dprintf_Pass1(char*,va_stack_t*,char** ,va_list) | 210 | 72 | 177 | 3h 34min | 34min | __Globals.dprintf_Pass1(char* ,va_stack_t*,char**,va_list) |
| Parse(idParser*,bool) | 262 | 43 | 174 | 3h 31min | 34min | idWindow.Parse(idParser*,bool) |
| dradfg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 248 | 47 | 171 | 3h 27min | 33min | __Globals.dradfg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| MatX_MultiplyMatX(idMatX&,constidMatX& ,constidMatX&) | 202 | 69 | 170 | 3h 26min | 33min | idSIMD_Generic.MatX_MultiplyMatX(idMatX& ,constidMatX&,constidMatX&) |
| ParseSingleFXAction(idLexer& ,idFXSingleAction&) | 207 | 67 | 170 | 3h 26min | 33min | idDeclFX.ParseSingleFXAction(idLexer& ,idFXSingleAction&) |
| InitFromFile(constchar*) | 204 | 66 | 168 | 3h 24min | 32min | roqParam.InitFromFile(constchar*) |
| SparseEncode() | 178 | 77 | 166 | 3h 21min | 32min | codec.SparseEncode() |
| Curl_ftp_nextconnect(structconnectdata*) | 188 | 71 | 165 | 3h 20min | 32min | __Globals.Curl_ftp_nextconnect (structconnectdata*) |
| CallFrameCommands(idEntity*,int,int) | 193 | 69 | 165 | 3h 20min | 32min | idAnim.CallFrameCommands(idEntity*,int ,int) |
| Rotation180(trace_t*,constidVec3& ,constidVec3&,constfloat,constfloat ,constidVec3&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 215 | 56 | 163 | 3h 18min | 31min | idCollisionModelManagerLocal.Rotation180 (trace_t*,constidVec3&,constidVec3& ,constfloat,constfloat,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| AddChannelContribution (idSoundEmitterLocal*,idSoundChannel* ,int,int,float*) | 175 | 75 | 162 | 3h 16min | 31min | idSoundWorldLocal.AddChannelContribution (idSoundEmitterLocal*,idSoundChannel* ,int,int,float*) |
| Translation(trace_t*,constidVec3& ,constidVec3&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 198 | 63 | 162 | 3h 16min | 31min | idCollisionModelManagerLocal.Translation (trace_t*,constidVec3&,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| ConvertLWOToModelSurfaces (conststructst_lwObject*) | 211 | 57 | 162 | 3h 16min | 31min | idRenderModelStatic .ConvertLWOToModelSurfaces (conststructst_lwObject*) |
| lwGetObject(constchar*,unsignedint*,int* ) | 164 | 75 | 157 | 3h 11min | 30min | __Globals.lwGetObject(constchar* ,unsignedint*,int*) |
| HandleEvent(constsysEvent_t*,bool*) | 142 | 80 | 151 | 3h 3min | 29min | idEditWindow.HandleEvent (constsysEvent_t*,bool*) |
| ParseParticleStage(idLexer&) | 151 | 76 | 151 | 3h 3min | 29min | idDeclParticle.ParseParticleStage (idLexer&) |
| RB_RenderInteraction(constdrawSurf_t*) | 205 | 48 | 150 | 3h 2min | 28min | __Globals.RB_RenderInteraction (constdrawSurf_t*) |
| Brush_MoveVertex(brush_t*,constidVec3& ,constidVec3&,idVec3&,bool) | 176 | 61 | 149 | 3h 1min | 28min | __Globals.Brush_MoveVertex(brush_t* ,constidVec3&,constidVec3&,idVec3&,bool) |
| Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) | 247 | 25 | 148 | 3h 0min | 28min | idSurface.Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) |
| GetWeaponDef(constchar*,int) | 228 | 33 | 147 | 2h 59min | 28min | idWeapon.GetWeaponDef(constchar*,int) |
| UpdateFocus() | 163 | 65 | 146 | 2h 57min | 27min | idPlayer.UpdateFocus() |
| OptimizeOpcode(constopcode_t*,idVarDef* ,idVarDef*) | 183 | 55 | 146 | 2h 57min | 27min | idCompiler.OptimizeOpcode(constopcode_t* ,idVarDef*,idVarDef*) |
| OptimizeOpcode(constopcode_t*,idVarDef* ,idVarDef*) | 183 | 55 | 146 | 2h 57min | 27min | idCompiler.OptimizeOpcode(constopcode_t* ,idVarDef*,idVarDef*) |
| HandleGuiCommands(constchar*) | 169 | 61 | 145 | 2h 56min | 27min | idMultiplayerGame.HandleGuiCommands (constchar*) |
| ConvertMAToModelSurfaces (conststructmaModel_s*) | 192 | 48 | 144 | 2h 55min | 27min | idRenderModelStatic .ConvertMAToModelSurfaces (conststructmaModel_s*) |
| OpenFileReadFlags(constchar*,int ,pack_t**,bool,constchar*) | 138 | 74 | 143 | 2h 54min | 27min | idFileSystemLocal.OpenFileReadFlags (constchar*,int,pack_t**,bool,constchar* ) |
| OpenFileReadFlags(constchar*,int ,pack_t**,bool,constchar*) | 138 | 74 | 143 | 2h 54min | 27min | idFileSystemLocal.OpenFileReadFlags (constchar*,int,pack_t**,bool,constchar* ) |
| Run(int) | 160 | 63 | 143 | 2h 54min | 27min | idEntityFx.Run(int) |
| TestDot() | 171 | 58 | 143 | 2h 54min | 27min | __Globals.TestDot() |
| ConvertASEToModelSurfaces (conststructaseModel_s*) | 192 | 47 | 143 | 2h 54min | 27min | idRenderModelStatic .ConvertASEToModelSurfaces (conststructaseModel_s*) |
| inflate_blocks(inflate_blocks_statef* ,z_streamp,int) | 189 | 47 | 141 | 2h 52min | 26min | __Globals.inflate_blocks (inflate_blocks_statef*,z_streamp,int) |
| inflate_blocks(inflate_blocks_statef* ,z_streamp,int) | 189 | 47 | 141 | 2h 52min | 26min | __Globals.inflate_blocks (inflate_blocks_statef*,z_streamp,int) |
| InverseSelf() | 278 | 2 | 141 | 2h 52min | 26min | idMat6.InverseSelf() |
| UpdateFocus() | 155 | 63 | 140 | 2h 50min | 26min | idPlayer.UpdateFocus() |
| TestCompare() | 162 | 58 | 139 | 2h 49min | 26min | __Globals.TestCompare() |
| HandleGuiCommands(constchar*) | 163 | 58 | 139 | 2h 49min | 26min | idMultiplayerGame.HandleGuiCommands (constchar*) |
| lwGetSurface(idFile*,int) | 170 | 53 | 138 | 2h 48min | 26min | __Globals.lwGetSurface(idFile*,int) |
| Patch_Weld(patchMesh_t*,patchMesh_t*) | 169 | 53 | 137 | 2h 47min | 25min | __Globals.Patch_Weld(patchMesh_t* ,patchMesh_t*) |
| MakeMegaTexture_f(constidCmdArgs&) | 182 | 43 | 134 | 2h 43min | 25min | idMegaTexture.MakeMegaTexture_f (constidCmdArgs&) |
| CreateFrame(int,bool) | 144 | 61 | 133 | 2h 42min | 25min | idAnimator.CreateFrame(int,bool) |
| CreateFrame(int,bool) | 144 | 61 | 133 | 2h 42min | 25min | idAnimator.CreateFrame(int,bool) |
| MatX_TransposeMultiplyMatX(idMatX& ,constidMatX&,constidMatX&) | 154 | 56 | 133 | 2h 42min | 25min | idSIMD_Generic .MatX_TransposeMultiplyMatX(idMatX& ,constidMatX&,constidMatX&) |
| MatX_MultiplyMatX(idMatX&,constidMatX& ,constidMatX&) | 157 | 55 | 133 | 2h 42min | 25min | idSIMD_SSE.MatX_MultiplyMatX(idMatX& ,constidMatX&,constidMatX&) |
| XY_Draw() | 162 | 52 | 133 | 2h 42min | 25min | CXYWnd.XY_Draw() |
| DrawPatchMesh(patchMesh_t*,bool,int* ,bool) | 150 | 57 | 132 | 2h 41min | 24min | __Globals.DrawPatchMesh(patchMesh_t* ,bool,int*,bool) |
| MD5Transform(UINT4*,unsignedchar*) | 263 | 1 | 132 | 2h 41min | 24min | __Globals.MD5Transform(UINT4* ,unsignedchar*) |
| WritePrecompressedImage() | 159 | 52 | 131 | 2h 40min | 24min | idImage.WritePrecompressedImage() |
| ClippedProjectionBounds(constidFrustum& ,constidBox&,idBounds&) | 140 | 60 | 130 | 2h 38min | 24min | idFrustum.ClippedProjectionBounds (constidFrustum&,constidBox&,idBounds&) |
| MakePreviousImage(quadcel*) | 147 | 57 | 130 | 2h 38min | 24min | codec.MakePreviousImage(quadcel*) |
| Parse(constchar*,constint) | 168 | 46 | 130 | 2h 38min | 24min | idDeclModelDef.Parse(constchar*,constint ) |
| Parse(constchar*,constint) | 168 | 46 | 130 | 2h 38min | 24min | idDeclModelDef.Parse(constchar*,constint ) |
| DeriveTangents(idPlane*,idDrawVert* ,constint,constint*,constint) | 226 | 17 | 130 | 2h 38min | 24min | idSIMD_SSE.DeriveTangents(idPlane* ,idDrawVert*,constint,constint*,constint ) |
| R_LocalTrace(constidVec3&,constidVec3& ,constfloat,constsrfTriangles_t*) | 141 | 59 | 129 | 2h 37min | 24min | __Globals.R_LocalTrace(constidVec3& ,constidVec3&,constfloat ,constsrfTriangles_t*) |
| Solve(constidMatX&,idVecX&,constidVecX& ,constidVecX&,constidVecX&,constint*) | 146 | 56 | 129 | 2h 37min | 24min | idLCP_Symmetric.Solve(constidMatX& ,idVecX&,constidVecX&,constidVecX& ,constidVecX&,constint*) |
| Entity_PostParse(entity_t*,brush_t*) | 156 | 51 | 129 | 2h 37min | 24min | __Globals.Entity_PostParse(entity_t* ,brush_t*) |
| Run(int) | 141 | 58 | 128 | 2h 36min | 23min | idEntityFx.Run(int) |
| LoadTGA(constchar*,byte**,int*,int* ,time_t*) | 170 | 43 | 128 | 2h 36min | 23min | __Globals.LoadTGA(constchar*,byte**,int* ,int*,time_t*) |
| Segment(int*,float*,int,float) | 171 | 43 | 128 | 2h 36min | 23min | codec.Segment(int*,float*,int,float) |
| Solve(constidMatX&,idVecX&,constidVecX& ,constidVecX&,constidVecX&,constint*) | 143 | 56 | 127 | 2h 35min | 23min | idLCP_Square.Solve(constidMatX&,idVecX& ,constidVecX&,constidVecX&,constidVecX& ,constint*) |
| ParseBody(idLexer&) | 110 | 71 | 126 | 2h 34min | 23min | idDeclAF.ParseBody(idLexer&) |
| Think() | 147 | 53 | 126 | 2h 34min | 23min | idPlayer.Think() |
| VQ(constint,constint,constunsignedchar* ,float*,double**,constbool) | 145 | 53 | 125 | 2h 32min | 23min | codec.VQ(constint,constint ,constunsignedchar*,float*,double** ,constbool) |
| ClientReadSnapshot(int,int,constint ,constint,constint,constint ,constidBitMsg&) | 146 | 52 | 125 | 2h 32min | 23min | idGameLocal.ClientReadSnapshot(int,int ,constint,constint,constint,constint ,constidBitMsg&) |
| WndProc(HWND,UINT,WPARAM,LPARAM) | 166 | 42 | 125 | 2h 32min | 23min | rvGENavigator.WndProc(HWND,UINT,WPARAM ,LPARAM) |
| RB_STD_T_RenderShaderPasses (constdrawSurf_t*) | 150 | 49 | 124 | 2h 31min | 23min | __Globals.RB_STD_T_RenderShaderPasses (constdrawSurf_t*) |
| ReadNumber(idToken*) | 124 | 59 | 121 | 2h 28min | 22min | idLexer.ReadNumber(idToken*) |
| read_markers(j_decompress_ptr) | 105 | 68 | 120 | 2h 27min | 22min | __Globals.read_markers(j_decompress_ptr) |
| R_ListImages_f(constidCmdArgs&) | 120 | 60 | 120 | 2h 27min | 22min | __Globals.R_ListImages_f(constidCmdArgs& ) |
| ClientReadSnapshot(int,int,constint ,constint,constint,constint ,constidBitMsg&) | 137 | 50 | 118 | 2h 24min | 21min | idGameLocal.ClientReadSnapshot(int,int ,constint,constint,constint,constint ,constidBitMsg&) |
| ParseShader(idLexer&) | 123 | 55 | 116 | 2h 22min | 21min | idSoundShader.ParseShader(idLexer&) |
| Critical Rule Violated: Avoid methods with too many parameters |
• Rule Description:
This rule matches methods with more than 8 parameters. Such method is painful to call and might degrade performance. See the definition of the NbParameters metric here: http://www.cppdepend.com/Metrics.aspx#NbParameters
• How to Fix Issues: More properties/fields can be added to the declaring type to handle numerous states. An alternative is to provide a class or a structure dedicated to handle arguments passing. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a method with 7 parameters, up to 6 hours for a methods with 40 or more parameters.
• How to Fix Issues: More properties/fields can be added to the declaring type to handle numerous states. An alternative is to provide a class or a structure dedicated to handle arguments passing. The estimated Debt, which means the effort to fix such issue, varies linearly from 1 hour for a method with 7 parameters, up to 6 hours for a methods with 40 or more parameters.
204 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 204 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 204 methods | # Parameters | Debt | Annual Interest | Full Name |
|---|---|---|---|---|
| idMat4(constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat) | 16 | 2h 21min | 34min | idMat4.idMat4(constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat) |
| AddHttpPost(char*,size_t,char*,size_t ,char*,size_t,char*,long ,structcurl_slist*,char* ,structcurl_httppost* ,structcurl_httppost** ,structcurl_httppost**) | 13 | 1h 54min | 23min | __Globals.AddHttpPost(char*,size_t,char* ,size_t,char*,size_t,char*,long ,structcurl_slist*,char* ,structcurl_httppost* ,structcurl_httppost** ,structcurl_httppost**) |
| Rotation180(trace_t*,constidVec3& ,constidVec3&,constfloat,constfloat ,constidVec3&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 12 | 1h 45min | 19min | idCollisionModelManagerLocal.Rotation180 (trace_t*,constidVec3&,constidVec3& ,constfloat,constfloat,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| TestTrajectory(constidVec3&,constidVec3& ,float,float,float,float ,constidClipModel*,int,constidEntity* ,constidEntity*,int) | 11 | 1h 36min | 16min | idAI.TestTrajectory(constidVec3& ,constidVec3&,float,float,float,float ,constidClipModel*,int,constidEntity* ,constidEntity*,int) |
| PredictTrajectory(constidVec3& ,constidVec3&,float,constidVec3& ,constidClipModel*,int,float ,constidEntity*,constidEntity*,int ,idVec3&) | 11 | 1h 36min | 16min | idAI.PredictTrajectory(constidVec3& ,constidVec3&,float,constidVec3& ,constidClipModel*,int,float ,constidEntity*,constidEntity*,int ,idVec3&) |
| ContactsModel(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) | 11 | 1h 36min | 16min | idClip.ContactsModel(contactInfo_t* ,constint,constidVec3&,constidVec6& ,constfloat,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) |
| Contacts(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) | 11 | 1h 36min | 16min | idCollisionModelManagerLocal.Contacts (contactInfo_t*,constint,constidVec3& ,constidVec6&,constfloat ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| ContactsModel(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) | 11 | 1h 36min | 16min | idClip.ContactsModel(contactInfo_t* ,constint,constidVec3&,constidVec6& ,constfloat,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) |
| TestTrajectory(constidVec3&,constidVec3& ,float,float,float,float ,constidClipModel*,int,constidEntity* ,constidEntity*,int) | 11 | 1h 36min | 16min | idAI.TestTrajectory(constidVec3& ,constidVec3&,float,float,float,float ,constidClipModel*,int,constidEntity* ,constidEntity*,int) |
| PredictTrajectory(constidVec3& ,constidVec3&,float,constidVec3& ,constidClipModel*,int,float ,constidEntity*,constidEntity*,int ,idVec3&) | 11 | 1h 36min | 16min | idAI.PredictTrajectory(constidVec3& ,constidVec3&,float,constidVec3& ,constidClipModel*,int,float ,constidEntity*,constidEntity*,int ,idVec3&) |
| huft_build(uInt*,uInt,uInt,constuInt* ,constuInt*,inflate_huft**,uInt* ,inflate_huft*,uInt*,uInt*) | 10 | 1h 27min | 12min | __Globals.huft_build(uInt*,uInt,uInt ,constuInt*,constuInt*,inflate_huft** ,uInt*,inflate_huft*,uInt*,uInt*) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 10 | 1h 27min | 12min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 10 | 1h 27min | 12min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| huft_build(uInt*,uInt,uInt,constuInt* ,constuInt*,inflate_huft**,uInt* ,inflate_huft*,uInt*,uInt*) | 10 | 1h 27min | 12min | __Globals.huft_build(uInt*,uInt,uInt ,constuInt*,constuInt*,inflate_huft** ,uInt*,inflate_huft*,uInt*,uInt*) |
| _vp_couple(int,vorbis_info_psy_global* ,vorbis_look_psy*,vorbis_info_mapping0* ,float**,float**,int**,int**,int*,int) | 10 | 1h 27min | 12min | __Globals._vp_couple(int ,vorbis_info_psy_global* ,vorbis_look_psy*,vorbis_info_mapping0* ,float**,float**,int**,int**,int*,int) |
| dradfg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 10 | 1h 27min | 12min | __Globals.dradfg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| dradbg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 10 | 1h 27min | 12min | __Globals.dradbg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| logMap2d(GLenum,GLdouble,GLdouble,GLint ,GLint,GLdouble,GLdouble,GLint,GLint ,constGLdouble*) | 10 | 1h 27min | 12min | __Globals.logMap2d(GLenum,GLdouble ,GLdouble,GLint,GLint,GLdouble,GLdouble ,GLint,GLint,constGLdouble*) |
| logMap2f(GLenum,GLfloat,GLfloat,GLint ,GLint,GLfloat,GLfloat,GLint,GLint ,constGLfloat*) | 10 | 1h 27min | 12min | __Globals.logMap2f(GLenum,GLfloat ,GLfloat,GLint,GLint,GLfloat,GLfloat ,GLint,GLint,constGLfloat*) |
| DrawStretchPic(constidDrawVert* ,constglIndex_t*,int,int ,constidMaterial*,bool,float,float,float ,float) | 10 | 1h 27min | 12min | idRenderSystemLocal.DrawStretchPic (constidDrawVert*,constglIndex_t*,int ,int,constidMaterial*,bool,float,float ,float,float) |
| DrawStretchPic(constidDrawVert* ,constglIndex_t*,int,int ,constidMaterial*,bool,float,float,float ,float) | 10 | 1h 27min | 12min | idGuiModel.DrawStretchPic (constidDrawVert*,constglIndex_t*,int ,int,constidMaterial*,bool,float,float ,float,float) |
| DrawStretchPic(constidDrawVert* ,constglIndex_t*,int,int ,constidMaterial*,bool,float,float,float ,float) | 10 | 1h 27min | 12min | idRenderSystem.DrawStretchPic (constidDrawVert*,constglIndex_t*,int ,int,constidMaterial*,bool,float,float ,float,float) |
| DrawTextA(constchar*,float,int,idVec4 ,idRectangle,bool,int,bool,idList<int>* ,int) | 10 | 1h 27min | 12min | idDeviceContext.DrawTextA(constchar* ,float,int,idVec4,idRectangle,bool,int ,bool,idList<int>*,int) |
| DrawStretchPicRotated(float,float,float ,float,float,float,float,float ,constidMaterial*,float) | 10 | 1h 27min | 12min | idDeviceContext.DrawStretchPicRotated (float,float,float,float,float,float ,float,float,constidMaterial*,float) |
| PaintChar(float,float,float,float,float ,float,float,float,float ,constidMaterial*) | 10 | 1h 27min | 12min | idDeviceContext.PaintChar(float,float ,float,float,float,float,float,float ,float,constidMaterial*) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 10 | 1h 27min | 12min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 10 | 1h 27min | 12min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| idMat3(constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat) | 9 | 1h 18min | 9min | idMat3.idMat3(constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat,constfloat,constfloat ,constfloat) |
| unzlocal_GetCurrentFileInfoInternal (unzFile,unz_file_info* ,unz_file_info_internal*,char*,uLong ,void*,uLong,char*,uLong) | 9 | 1h 18min | 9min | __Globals .unzlocal_GetCurrentFileInfoInternal (unzFile,unz_file_info* ,unz_file_info_internal*,char*,uLong ,void*,uLong,char*,uLong) |
| inflate_trees_dynamic(uInt,uInt,uInt* ,uInt*,uInt*,inflate_huft** ,inflate_huft**,inflate_huft*,z_streamp) | 9 | 1h 18min | 9min | __Globals.inflate_trees_dynamic(uInt ,uInt,uInt*,uInt*,uInt*,inflate_huft** ,inflate_huft**,inflate_huft*,z_streamp) |
| GetObstacles(constidPhysics*,constidAAS* ,constidEntity*,int,constidVec3& ,constidVec3&,obstacle_t*,int,idBounds&) | 9 | 1h 18min | 9min | __Globals.GetObstacles(constidPhysics* ,constidAAS*,constidEntity*,int ,constidVec3&,constidVec3&,obstacle_t* ,int,idBounds&) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| Contacts(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,constidEntity*) | 9 | 1h 18min | 9min | idClip.Contacts(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,constidEntity*) |
| TranslationModel(trace_t&,constidVec3& ,constidVec3&,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idClip.TranslationModel(trace_t& ,constidVec3&,constidVec3& ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| RotationModel(trace_t&,constidVec3& ,constidRotation&,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idClip.RotationModel(trace_t& ,constidVec3&,constidRotation& ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| Translation(trace_t*,constidVec3& ,constidVec3&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idCollisionModelManagerLocal.Translation (trace_t*,constidVec3&,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| Rotation(trace_t*,constidVec3& ,constidRotation&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idCollisionModelManagerLocal.Rotation (trace_t*,constidVec3&,constidRotation& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| RotatePointThroughEpsilonPlane (constcm_traceWork_t*,constidVec3& ,constidVec3&,constidPlane&,constfloat ,constidVec3&,float&,idVec3&,idVec3&) | 9 | 1h 18min | 9min | idCollisionModelManagerLocal .RotatePointThroughEpsilonPlane (constcm_traceWork_t*,constidVec3& ,constidVec3&,constidPlane&,constfloat ,constidVec3&,float&,idVec3&,idVec3&) |
| unzlocal_GetCurrentFileInfoInternal (unzFile,unz_file_info* ,unz_file_info_internal*,char*,uLong ,void*,uLong,char*,uLong) | 9 | 1h 18min | 9min | __Globals .unzlocal_GetCurrentFileInfoInternal (unzFile,unz_file_info* ,unz_file_info_internal*,char*,uLong ,void*,uLong,char*,uLong) |
| inflate_trees_dynamic(uInt,uInt,uInt* ,uInt*,uInt*,inflate_huft** ,inflate_huft**,inflate_huft*,z_streamp) | 9 | 1h 18min | 9min | __Globals.inflate_trees_dynamic(uInt ,uInt,uInt*,uInt*,uInt*,inflate_huft** ,inflate_huft**,inflate_huft*,z_streamp) |
| logTexImage2D(GLenum,GLint,GLint,GLsizei ,GLsizei,GLint,GLenum,GLenum ,constGLvoid*) | 9 | 1h 18min | 9min | __Globals.logTexImage2D(GLenum,GLint ,GLint,GLsizei,GLsizei,GLint,GLenum ,GLenum,constGLvoid*) |
| logTexSubImage2D(GLenum,GLint,GLint ,GLint,GLsizei,GLsizei,GLenum,GLenum ,constGLvoid*) | 9 | 1h 18min | 9min | __Globals.logTexSubImage2D(GLenum,GLint ,GLint,GLint,GLsizei,GLsizei,GLenum ,GLenum,constGLvoid*) |
| GLColoredBoxWithLabel(float,float,float ,idVec4,constchar*,idVec4,float,float ,float) | 9 | 1h 18min | 9min | __Globals.GLColoredBoxWithLabel(float ,float,float,idVec4,constchar*,idVec4 ,float,float,float) |
| DrawStretchPic(float,float,float,float ,float,float,float,float ,constidMaterial*) | 9 | 1h 18min | 9min | idRenderSystemLocal.DrawStretchPic(float ,float,float,float,float,float,float ,float,constidMaterial*) |
| DrawStretchPic(float,float,float,float ,float,float,float,float ,constidMaterial*) | 9 | 1h 18min | 9min | idGuiModel.DrawStretchPic(float,float ,float,float,float,float,float,float ,constidMaterial*) |
| DrawStretchPic(float,float,float,float ,float,float,float,float ,constidMaterial*) | 9 | 1h 18min | 9min | idRenderSystem.DrawStretchPic(float ,float,float,float,float,float,float ,float,constidMaterial*) |
| StretchBlt(HDC,int,int,int,int,int,int ,int,int) | 9 | 1h 18min | 9min | CDIB.StretchBlt(HDC,int,int,int,int,int ,int,int,int) |
| StretchBlt(int,int,int,int,CDIB&,int,int ,int,int) | 9 | 1h 18min | 9min | CDIB.StretchBlt(int,int,int,int,CDIB& ,int,int,int,int) |
| ExpandBlt(int,int,int,int,CDIB&,int,int ,int,int) | 9 | 1h 18min | 9min | CDIB.ExpandBlt(int,int,int,int,CDIB&,int ,int,int,int) |
| Expand(int,int,int,int,CDIB&,int,int,int ,int) | 9 | 1h 18min | 9min | CDIB.Expand(int,int,int,int,CDIB&,int ,int,int,int) |
| DrawStretchPic(float,float,float,float ,float,float,float,float ,constidMaterial*) | 9 | 1h 18min | 9min | idDeviceContext.DrawStretchPic(float ,float,float,float,float,float,float ,float,constidMaterial*) |
| DrawMaterialRotated(float,float,float ,float,constidMaterial*,constidVec4& ,float,float,float) | 9 | 1h 18min | 9min | idDeviceContext.DrawMaterialRotated (float,float,float,float ,constidMaterial*,constidVec4&,float ,float,float) |
| DrawTextA(float,float,float,idVec4 ,constchar*,float,int,int,int) | 9 | 1h 18min | 9min | idDeviceContext.DrawTextA(float,float ,float,idVec4,constchar*,float,int,int ,int) |
| GetObstacles(constidPhysics*,constidAAS* ,constidEntity*,int,constidVec3& ,constidVec3&,obstacle_t*,int,idBounds&) | 9 | 1h 18min | 9min | __Globals.GetObstacles(constidPhysics* ,constidAAS*,constidEntity*,int ,constidVec3&,constidVec3&,obstacle_t* ,int,idBounds&) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 | 1h 18min | 9min | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| Contacts(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,constidEntity*) | 9 | 1h 18min | 9min | idClip.Contacts(contactInfo_t*,constint ,constidVec3&,constidVec6&,constfloat ,constidClipModel*,constidMat3&,int ,constidEntity*) |
| TranslationModel(trace_t&,constidVec3& ,constidVec3&,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idClip.TranslationModel(trace_t& ,constidVec3&,constidVec3& ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| RotationModel(trace_t&,constidVec3& ,constidRotation&,constidClipModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 9 | 1h 18min | 9min | idClip.RotationModel(trace_t& ,constidVec3&,constidRotation& ,constidClipModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| ClipLine(constidVec3*,constidVec3*,int ,int,idVec3&,idVec3&,int&,int&) | 8 | 1h 9min | 5min | idFrustum.ClipLine(constidVec3* ,constidVec3*,int,int,idVec3&,idVec3& ,int&,int&) |
| unzGetCurrentFileInfo(unzFile ,unz_file_info*,char*,uLong,void*,uLong ,char*,uLong) | 8 | 1h 9min | 5min | __Globals.unzGetCurrentFileInfo(unzFile ,unz_file_info*,char*,uLong,void*,uLong ,char*,uLong) |
| FindNearestGoal(aasGoal_t&,int ,constidVec3,constidVec3&,int ,aasObstacle_t*,int,idAASCallback&) | 8 | 1h 9min | 5min | idAAS.FindNearestGoal(aasGoal_t&,int ,constidVec3,constidVec3&,int ,aasObstacle_t*,int,idAASCallback&) |
| FindNearestGoal(aasGoal_t&,int ,constidVec3,constidVec3&,int ,aasObstacle_t*,int,idAASCallback&) | 8 | 1h 9min | 5min | idAASLocal.FindNearestGoal(aasGoal_t& ,int,constidVec3,constidVec3&,int ,aasObstacle_t*,int,idAASCallback&) |
| GetFirstBlockingObstacle (constobstacle_t*,int,int,constidVec2& ,constidVec2&,float&,int&,int&) | 8 | 1h 9min | 5min | __Globals.GetFirstBlockingObstacle (constobstacle_t*,int,int,constidVec2& ,constidVec2&,float&,int&,int&) |
| PredictPath(constidEntity*,constidAAS* ,constidVec3&,constidVec3&,int,int,int ,predictedPath_t&) | 8 | 1h 9min | 5min | idAI.PredictPath(constidEntity* ,constidAAS*,constidVec3&,constidVec3& ,int,int,int,predictedPath_t&) |
| BlendAnim(int,int,int,idJointQuat* ,float&,bool,bool,bool) | 8 | 1h 9min | 5min | idAnimBlend.BlendAnim(int,int,int ,idJointQuat*,float&,bool,bool,bool) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| Motion(trace_t&,constidVec3& ,constidVec3&,constidRotation& ,constidClipModel*,constidMat3&,int ,constidEntity*) | 8 | 1h 9min | 5min | idClip.Motion(trace_t&,constidVec3& ,constidVec3&,constidRotation& ,constidClipModel*,constidMat3&,int ,constidEntity*) |
| Setup(idAFBody*,idAFBody*,constidVec3& ,constidVec3&,constidVec3&,constfloat ,constfloat,constidVec3&) | 8 | 1h 9min | 5min | idAFConstraint_PyramidLimit.Setup (idAFBody*,idAFBody*,constidVec3& ,constidVec3&,constidVec3&,constfloat ,constfloat,constidVec3&) |
| CollisionBetweenEdgeBounds (cm_traceWork_t*,constidVec3& ,constidVec3&,constidVec3&,constidVec3& ,float,idVec3&,idVec3&) | 8 | 1h 9min | 5min | idCollisionModelManagerLocal .CollisionBetweenEdgeBounds (cm_traceWork_t*,constidVec3& ,constidVec3&,constidVec3&,constidVec3& ,float,idVec3&,idVec3&) |
| ContentsTrm(trace_t*,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) | 8 | 1h 9min | 5min | idCollisionModelManagerLocal.ContentsTrm (trace_t*,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| unzGetCurrentFileInfo(unzFile ,unz_file_info*,char*,uLong,void*,uLong ,char*,uLong) | 8 | 1h 9min | 5min | __Globals.unzGetCurrentFileInfo(unzFile ,unz_file_info*,char*,uLong,void*,uLong ,char*,uLong) |
| RB_AddDebugText(constchar*,constidVec3& ,float,constidVec4&,constidMat3& ,constint,constint,constbool) | 8 | 1h 9min | 5min | __Globals.RB_AddDebugText(constchar* ,constidVec3&,float,constidVec4& ,constidMat3&,constint,constint ,constbool) |
| vorbis_lsp_to_curve(float*,int*,int,int ,float*,int,float,float) | 8 | 1h 9min | 5min | __Globals.vorbis_lsp_to_curve(float* ,int*,int,int,float*,int,float,float) |
| _ov_splice(float**,float**,int,int,int ,int,float*,float*) | 8 | 1h 9min | 5min | __Globals._ov_splice(float**,float**,int ,int,int,int,float*,float*) |
| Sys_FPU_PrintStateFlags(char*,int,int ,int,int,int,int,int) | 8 | 1h 9min | 5min | __Globals.Sys_FPU_PrintStateFlags(char* ,int,int,int,int,int,int,int) |
| logCopyTexImage2D(GLenum,GLint,GLenum ,GLint,GLint,GLsizei,GLsizei,GLint) | 8 | 1h 9min | 5min | __Globals.logCopyTexImage2D(GLenum,GLint ,GLenum,GLint,GLint,GLsizei,GLsizei ,GLint) |
| logCopyTexSubImage2D(GLenum,GLint,GLint ,GLint,GLint,GLint,GLsizei,GLsizei) | 8 | 1h 9min | 5min | __Globals.logCopyTexSubImage2D(GLenum ,GLint,GLint,GLint,GLint,GLint,GLsizei ,GLsizei) |
| logTexImage1D(GLenum,GLint,GLint,GLsizei ,GLint,GLenum,GLenum,constGLvoid*) | 8 | 1h 9min | 5min | __Globals.logTexImage1D(GLenum,GLint ,GLint,GLsizei,GLint,GLenum,GLenum ,constGLvoid*) |
| TraceToMeshFace(constsrfTriangles_t*,int ,float,float,constidVec3&,constidVec3& ,idVec3&,byte*) | 8 | 1h 9min | 5min | __Globals.TraceToMeshFace (constsrfTriangles_t*,int,float,float ,constidVec3&,constidVec3&,idVec3&,byte* ) |
| parseRange(constchar*,int,int*,int*,int* ,int*,bool*,int*) | 8 | 1h 9min | 5min | __Globals.parseRange(constchar*,int,int* ,int*,int*,int*,bool*,int*) |
| parseTimecodeRange(constchar*,int,int* ,int*,int*,int*,bool*,int*) | 8 | 1h 9min | 5min | __Globals.parseTimecodeRange(constchar* ,int,int*,int*,int*,int*,bool*,int*) |
| Patch_Combine(patchMesh_t*,patchMesh_t* ,int,int,int,int,bool,bool) | 8 | 1h 9min | 5min | __Globals.Patch_Combine(patchMesh_t* ,patchMesh_t*,int,int,int,int,bool,bool) |
| Generate3DImage(constbyte*,int,int,int ,textureFilter_t,bool,textureRepeat_t ,textureDepth_t) | 8 | 1h 9min | 5min | idImage.Generate3DImage(constbyte*,int ,int,int,textureFilter_t,bool ,textureRepeat_t,textureDepth_t) |
| DrawTextA(constchar*,constidVec3&,float ,constidVec4&,constidMat3&,constint ,constint,bool) | 8 | 1h 9min | 5min | idRenderWorldLocal.DrawTextA(constchar* ,constidVec3&,float,constidVec4& ,constidMat3&,constint,constint,bool) |
| BitBlt(int,int,int,int,CDIB&,int,int ,BYTE*) | 8 | 1h 9min | 5min | CDIB.BitBlt(int,int,int,int,CDIB&,int ,int,BYTE*) |
| DrawMaterial(float,float,float,float ,constidMaterial*,constidVec4&,float ,float) | 8 | 1h 9min | 5min | idDeviceContext.DrawMaterial(float,float ,float,float,constidMaterial* ,constidVec4&,float,float) |
| ClippedCoords(float*,float*,float* ,float*,float*,float*,float*,float*) | 8 | 1h 9min | 5min | idDeviceContext.ClippedCoords(float* ,float*,float*,float*,float*,float* ,float*,float*) |
| Init(idGameSSDWindow*,constidVec3& ,constidVec2&,int,int,SSDEntity*,bool ,bool) | 8 | 1h 9min | 5min | SSDExplosion.Init(idGameSSDWindow* ,constidVec3&,constidVec2&,int,int ,SSDEntity*,bool,bool) |
| GetNewExplosion(idGameSSDWindow* ,constidVec3&,constidVec2&,int,int ,SSDEntity*,bool,bool) | 8 | 1h 9min | 5min | SSDExplosion.GetNewExplosion (idGameSSDWindow*,constidVec3& ,constidVec2&,int,int,SSDEntity*,bool ,bool) |
| InitWithDefaults(constchar* ,constidRectangle&,constidVec4& ,constidVec4&,constchar*,constchar*,bool ,bool) | 8 | 1h 9min | 5min | idSliderWindow.InitWithDefaults (constchar*,constidRectangle& ,constidVec4&,constidVec4&,constchar* ,constchar*,bool,bool) |
| GetFirstBlockingObstacle (constobstacle_t*,int,int,constidVec2& ,constidVec2&,float&,int&,int&) | 8 | 1h 9min | 5min | __Globals.GetFirstBlockingObstacle (constobstacle_t*,int,int,constidVec2& ,constidVec2&,float&,int&,int&) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 8 | 1h 9min | 5min | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| Rule Violated: Avoid methods with too many local variables |
• Rule Description:
This rule matches methods with more than 15 variables.
Methods where NbVariables > 8 are hard to understand and maintain. Methods where NbVariables > 15 are extremely complex and must be refactored.
See the definition of the Nbvariables metric here: http://www.cppdepend.com/Metrics.aspx#Nbvariables
• How to Fix Issues: To refactor such method and increase code quality and maintainability, certainly you'll have to split the method into several smaller methods or even create one or several classes to implement the logic. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). The estimated Debt, which means the effort to fix such issue, varies linearly from 10 minutes for a method with 15 variables, up to 2 hours for a methods with 80 or more variables.
• How to Fix Issues: To refactor such method and increase code quality and maintainability, certainly you'll have to split the method into several smaller methods or even create one or several classes to implement the logic. During this process it is important to question the scope of each variable local to the method. This can be an indication if such local variable will become an instance field of the newly created class(es). The estimated Debt, which means the effort to fix such issue, varies linearly from 10 minutes for a method with 15 variables, up to 2 hours for a methods with 80 or more variables.
291 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 291 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 291 methods | # Variables | Debt | Annual Interest | Full Name |
|---|---|---|---|---|
| InverseSelf() | 238 | 6h 0min | 2h 0min | idMat6.InverseSelf() |
| InverseSelf() | 97 | 6h 0min | 2h 0min | idMat5.InverseSelf() |
| Reachability_Step_Barrier_WaterJump_Walk OffLedge(int,int) | 72 | 5h 23min | 1h 45min | idAASReach .Reachability_Step_Barrier_WaterJump_Wal kOffLedge(int,int) |
| Determinant() | 56 | 4h 9min | 1h 16min | idMat6.Determinant() |
| ConvertLWOToModelSurfaces (conststructst_lwObject*) | 48 | 3h 32min | 1h 1min | idRenderModelStatic .ConvertLWOToModelSurfaces (conststructst_lwObject*) |
| ConvertASEToModelSurfaces (conststructaseModel_s*) | 47 | 3h 27min | 1h 0min | idRenderModelStatic .ConvertASEToModelSurfaces (conststructaseModel_s*) |
| ConvertMAToModelSurfaces (conststructmaModel_s*) | 47 | 3h 27min | 1h 0min | idRenderModelStatic .ConvertMAToModelSurfaces (conststructmaModel_s*) |
| CreateConnection(structSessionHandle* ,structconnectdata** ,structCurl_dns_entry**,bool*) | 46 | 3h 23min | 58min | __Globals.CreateConnection (structSessionHandle* ,structconnectdata** ,structCurl_dns_entry**,bool*) |
| DeriveTangents(idPlane*,idDrawVert* ,constint,constint*,constint) | 45 | 3h 18min | 56min | idSIMD_SSE.DeriveTangents(idPlane* ,idDrawVert*,constint,constint*,constint ) |
| mapping0_forward(vorbis_block*) | 45 | 3h 18min | 56min | __Globals.mapping0_forward(vorbis_block* ) |
| DeriveUnsmoothedTangents(idDrawVert* ,constdominantTri_s*,constint) | 44 | 3h 13min | 54min | idSIMD_SSE.DeriveUnsmoothedTangents (idDrawVert*,constdominantTri_s* ,constint) |
| Parse(idParser*,bool) | 43 | 3h 9min | 52min | idWindow.Parse(idParser*,bool) |
| GetObstacles(constidPhysics*,constidAAS* ,constidEntity*,int,constidVec3& ,constidVec3&,obstacle_t*,int,idBounds&) | 42 | 3h 4min | 51min | __Globals.GetObstacles(constidPhysics* ,constidAAS*,constidEntity*,int ,constidVec3&,constidVec3&,obstacle_t* ,int,idBounds&) |
| GetObstacles(constidPhysics*,constidAAS* ,constidEntity*,int,constidVec3& ,constidVec3&,obstacle_t*,int,idBounds&) | 42 | 3h 4min | 51min | __Globals.GetObstacles(constidPhysics* ,constidAAS*,constidEntity*,int ,constidVec3&,constidVec3&,obstacle_t* ,int,idBounds&) |
| ClippedProjectionBounds(constidFrustum& ,constidBox&,idBounds&) | 38 | 2h 46min | 43min | idFrustum.ClippedProjectionBounds (constidFrustum&,constidBox&,idBounds&) |
| Evaluate() | 38 | 2h 46min | 43min | idIK_Walk.Evaluate() |
| Curl_readwrite(structconnectdata*,bool*) | 38 | 2h 46min | 43min | __Globals.Curl_readwrite (structconnectdata*,bool*) |
| floor1_encode(vorbis_block* ,vorbis_look_floor1*,int*,int*) | 38 | 2h 46min | 43min | __Globals.floor1_encode(vorbis_block* ,vorbis_look_floor1*,int*,int*) |
| Evaluate() | 38 | 2h 46min | 43min | idIK_Walk.Evaluate() |
| R_ParticleDeform(drawSurf_t*,bool) | 37 | 2h 41min | 41min | __Globals.R_ParticleDeform(drawSurf_t* ,bool) |
| Entity_PostParse(entity_t*,brush_t*) | 37 | 2h 41min | 41min | __Globals.Entity_PostParse(entity_t* ,brush_t*) |
| Segment(int*,float*,int,float) | 37 | 2h 41min | 41min | codec.Segment(int*,float*,int,float) |
| InverseSelf() | 36 | 2h 36min | 40min | idMat4.InverseSelf() |
| floor1_fit(vorbis_block* ,vorbis_look_floor1*,constfloat* ,constfloat*) | 36 | 2h 36min | 40min | __Globals.floor1_fit(vorbis_block* ,vorbis_look_floor1*,constfloat* ,constfloat*) |
| RenderBumpFlat_f(constidCmdArgs&) | 36 | 2h 36min | 40min | __Globals.RenderBumpFlat_f (constidCmdArgs&) |
| GetWeaponDef(constchar*,int) | 36 | 2h 36min | 40min | idWeapon.GetWeaponDef(constchar*,int) |
| AF_CreateMesh(constidDict&,idVec3& ,idMat3&,bool&) | 35 | 2h 32min | 38min | idGameEdit.AF_CreateMesh(constidDict& ,idVec3&,idMat3&,bool&) |
| dradfg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 35 | 2h 32min | 38min | __Globals.dradfg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| dradbg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 35 | 2h 32min | 38min | __Globals.dradbg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| AF_CreateMesh(constidDict&,idVec3& ,idMat3&,bool&) | 35 | 2h 32min | 38min | idGameEdit.AF_CreateMesh(constidDict& ,idVec3&,idMat3&,bool&) |
| ProjectionIntegrals(int,int,int ,structprojectionIntegrals_s&) | 34 | 2h 27min | 36min | idTraceModel.ProjectionIntegrals(int,int ,int,structprojectionIntegrals_s&) |
| RasterizeTriangle(constsrfTriangles_t* ,constidVec3*,int,renderBump_t*) | 34 | 2h 27min | 36min | __Globals.RasterizeTriangle (constsrfTriangles_t*,constidVec3*,int ,renderBump_t*) |
| ClientProcessReliableMessage(int ,constidBitMsg&) | 33 | 2h 23min | 34min | idGameLocal.ClientProcessReliableMessage (int,constidBitMsg&) |
| UpdateFocus() | 33 | 2h 23min | 34min | idPlayer.UpdateFocus() |
| Test() | 32 | 2h 18min | 32min | idMatX.Test() |
| Patch_Weld(patchMesh_t*,patchMesh_t*) | 32 | 2h 18min | 32min | __Globals.Patch_Weld(patchMesh_t* ,patchMesh_t*) |
| HandleMainMenuCommands(constchar*) | 32 | 2h 18min | 32min | idSessionLocal.HandleMainMenuCommands (constchar*) |
| ClientProcessReliableMessage(int ,constidBitMsg&) | 31 | 2h 13min | 31min | idGameLocal.ClientProcessReliableMessage (int,constidBitMsg&) |
| UpdateFocus() | 31 | 2h 13min | 31min | idPlayer.UpdateFocus() |
| Select_AutoCaulk() | 31 | 2h 13min | 31min | __Globals.Select_AutoCaulk() |
| ParticleOrigin(particleGen_t*,idVec3&) | 30 | 2h 9min | 29min | idParticleStage.ParticleOrigin (particleGen_t*,idVec3&) |
| AddChannelContribution (idSoundEmitterLocal*,idSoundChannel* ,int,int,float*) | 30 | 2h 9min | 29min | idSoundWorldLocal.AddChannelContribution (idSoundEmitterLocal*,idSoundChannel* ,int,int,float*) |
| Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) | 29 | 2h 4min | 27min | idSurface.Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) |
| Curl_ldap(structconnectdata*) | 29 | 2h 4min | 27min | __Globals.Curl_ldap(structconnectdata*) |
| MakeMegaTexture_f(constidCmdArgs&) | 29 | 2h 4min | 27min | idMegaTexture.MakeMegaTexture_f (constidCmdArgs&) |
| VQ(constint,constint,constunsignedchar* ,float*,double**,constbool) | 29 | 2h 4min | 27min | codec.VQ(constint,constint ,constunsignedchar*,float*,double** ,constbool) |
| HessenbergToRealSchur(idMatX&,idVecX& ,idVecX&) | 28 | 2h 0min | 25min | idMatX.HessenbergToRealSchur(idMatX& ,idVecX&,idVecX&) |
| R_EyeballDeform(drawSurf_t*) | 28 | 2h 0min | 25min | __Globals.R_EyeballDeform(drawSurf_t*) |
| Patch_Combine(patchMesh_t*,patchMesh_t* ,int,int,int,int,bool,bool) | 28 | 2h 0min | 25min | __Globals.Patch_Combine(patchMesh_t* ,patchMesh_t*,int,int,int,int,bool,bool) |
| ImageForTime(constint,constbool) | 28 | 2h 0min | 25min | idSoundSystemLocal.ImageForTime(constint ,constbool) |
| WndProc(HWND,UINT,WPARAM,LPARAM) | 28 | 2h 0min | 25min | rvGENavigator.WndProc(HWND,UINT,WPARAM ,LPARAM) |
| CreateMesh(float) | 28 | 2h 0min | 25min | idMayaExport.CreateMesh(float) |
| DeriveUnsmoothedTangents(idDrawVert* ,constdominantTri_s*,constint) | 27 | 1h 55min | 23min | idSIMD_Generic.DeriveUnsmoothedTangents (idDrawVert*,constdominantTri_s* ,constint) |
| dprintf_formatf(void*,int(*)(int,FILE*) ,constchar*,va_list) | 27 | 1h 55min | 23min | __Globals.dprintf_formatf(void*,int(*) (int,FILE*),constchar*,va_list) |
| FvqData(byte*,int,int,int,quadcel*,bool) | 27 | 1h 55min | 23min | codec.FvqData(byte*,int,int,int,quadcel* ,bool) |
| HandleGuiCommands(constchar*) | 27 | 1h 55min | 23min | idMultiplayerGame.HandleGuiCommands (constchar*) |
| AuxiliaryForces(float) | 26 | 1h 50min | 21min | idPhysics_AF.AuxiliaryForces(float) |
| HandleGuiCommands(constchar*) | 26 | 1h 50min | 21min | idMultiplayerGame.HandleGuiCommands (constchar*) |
| Curl_http(structconnectdata*) | 26 | 1h 50min | 21min | __Globals.Curl_http(structconnectdata*) |
| Rotation180(trace_t*,constidVec3& ,constidVec3&,constfloat,constfloat ,constidVec3&,constidTraceModel* ,constidMat3&,int,cmHandle_t ,constidVec3&,constidMat3&) | 26 | 1h 50min | 21min | idCollisionModelManagerLocal.Rotation180 (trace_t*,constidVec3&,constidVec3& ,constfloat,constfloat,constidVec3& ,constidTraceModel*,constidMat3&,int ,cmHandle_t,constidVec3&,constidMat3&) |
| R_CreateTurboShadowVolume (constidRenderEntityLocal* ,constsrfTriangles_t* ,constidRenderLightLocal*,srfCullInfo_t& ) | 26 | 1h 50min | 21min | __Globals.R_CreateTurboShadowVolume (constidRenderEntityLocal* ,constsrfTriangles_t* ,constidRenderLightLocal*,srfCullInfo_t& ) |
| vorbis_synthesis_blockin (vorbis_dsp_state*,vorbis_block*) | 26 | 1h 50min | 21min | __Globals.vorbis_synthesis_blockin (vorbis_dsp_state*,vorbis_block*) |
| dradb4(int,int,float*,float*,float* ,float*,float*) | 26 | 1h 50min | 21min | __Globals.dradb4(int,int,float*,float* ,float*,float*,float*) |
| GEItescriptsDlg_Apply(HWND) | 26 | 1h 50min | 21min | __Globals.GEItescriptsDlg_Apply(HWND) |
| LoadFLT(constchar*) | 26 | 1h 50min | 21min | idRenderModelStatic.LoadFLT(constchar*) |
| AuxiliaryForces(float) | 26 | 1h 50min | 21min | idPhysics_AF.AuxiliaryForces(float) |
| Determinant() | 25 | 1h 46min | 20min | idMat5.Determinant() |
| SlideMove(bool,bool,bool,bool) | 25 | 1h 46min | 20min | idPhysics_Player.SlideMove(bool,bool ,bool,bool) |
| dradb3(int,int,float*,float*,float* ,float*) | 25 | 1h 46min | 20min | __Globals.dradb3(int,int,float*,float* ,float*,float*) |
| Brush_DrawCombatNode(brush_t*,bool,bool) | 25 | 1h 46min | 20min | __Globals.Brush_DrawCombatNode(brush_t* ,bool,bool) |
| ParticleVerts(particleGen_t*,constidVec3 ,idDrawVert*) | 25 | 1h 46min | 20min | idParticleStage.ParticleVerts (particleGen_t*,constidVec3,idDrawVert*) |
| CreateOverlay(constidRenderModel* ,constidPlane*,constidMaterial*) | 25 | 1h 46min | 20min | idRenderModelOverlay.CreateOverlay (constidRenderModel*,constidPlane* ,constidMaterial*) |
| HandleEvent(constsysEvent_t*,bool*) | 25 | 1h 46min | 20min | idWindow.HandleEvent(constsysEvent_t* ,bool*) |
| SlideMove(bool,bool,bool,bool) | 25 | 1h 46min | 20min | idPhysics_Player.SlideMove(bool,bool ,bool,bool) |
| BlendJoints(idJointQuat* ,constidJointQuat*,constfloat,constint* ,constint) | 24 | 1h 41min | 18min | idSIMD_SSE.BlendJoints(idJointQuat* ,constidJointQuat*,constfloat,constint* ,constint) |
| R_ListImages_f(constidCmdArgs&) | 24 | 1h 41min | 18min | __Globals.R_ListImages_f(constidCmdArgs& ) |
| R_FlareDeform(drawSurf_t*) | 24 | 1h 41min | 18min | __Globals.R_FlareDeform(drawSurf_t*) |
| drfti1(int,float*,int*) | 24 | 1h 41min | 18min | __Globals.drfti1(int,float*,int*) |
| dradf4(int,int,float*,float*,float* ,float*,float*) | 24 | 1h 41min | 18min | __Globals.dradf4(int,int,float*,float* ,float*,float*,float*) |
| FragmentSilQuad(silQuad_t,silPlane_t* ,shadowOptEdge_t*,shadowOptEdge_t*) | 24 | 1h 41min | 18min | __Globals.FragmentSilQuad(silQuad_t ,silPlane_t*,shadowOptEdge_t* ,shadowOptEdge_t*) |
| ProcessConnectMessage(constnetadr_t ,constidBitMsg&) | 24 | 1h 41min | 18min | idAsyncServer.ProcessConnectMessage (constnetadr_t,constidBitMsg&) |
| Trace(modelTrace_t&,constidVec3& ,constidVec3&,constfloat,bool,bool) | 24 | 1h 41min | 18min | idRenderWorldLocal.Trace(modelTrace_t& ,constidVec3&,constidVec3&,constfloat ,bool,bool) |
| FindAmplitude(idSoundEmitterLocal* ,constint,constidVec3* ,consts_channelType,bool) | 24 | 1h 41min | 18min | idSoundWorldLocal.FindAmplitude (idSoundEmitterLocal*,constint ,constidVec3*,consts_channelType,bool) |
| Update(idPlayer*,bool) | 24 | 1h 41min | 18min | idGrabber.Update(idPlayer*,bool) |
| Explode(consttrace_t&,idEntity*) | 24 | 1h 41min | 18min | idProjectile.Explode(consttrace_t& ,idEntity*) |
| LaunchProjectile(constchar*,idEntity* ,bool) | 24 | 1h 41min | 18min | idAI.LaunchProjectile(constchar* ,idEntity*,bool) |
| UpdateAnimationControllers() | 24 | 1h 41min | 18min | idAI.UpdateAnimationControllers() |
| ClipInPlace(constidPlane&,constfloat ,constbool) | 23 | 1h 36min | 16min | idSurface.ClipInPlace(constidPlane& ,constfloat,constbool) |
| Curl_cookie_add(structSessionHandle* ,structCookieInfo*,bool,char*,char* ,char*) | 23 | 1h 36min | 16min | __Globals.Curl_cookie_add (structSessionHandle*,structCookieInfo* ,bool,char*,char*,char*) |
| LoadTGA(constchar*,byte**,int*,int* ,time_t*) | 23 | 1h 36min | 16min | __Globals.LoadTGA(constchar*,byte**,int* ,int*,time_t*) |
| R_MakeAmbientMap_f(constidCmdArgs&) | 23 | 1h 36min | 16min | __Globals.R_MakeAmbientMap_f (constidCmdArgs&) |
| make_sv(constpolyhedron&,idVec4) | 23 | 1h 36min | 16min | __Globals.make_sv(constpolyhedron& ,idVec4) |
| R_CreateVertexProgramTurboShadowVolume (constidRenderEntityLocal* ,constsrfTriangles_t* ,constidRenderLightLocal*,srfCullInfo_t& ) | 23 | 1h 36min | 16min | __Globals .R_CreateVertexProgramTurboShadowVolume (constidRenderEntityLocal* ,constsrfTriangles_t* ,constidRenderLightLocal*,srfCullInfo_t& ) |
| Brush_MoveVertex(brush_t*,constidVec3& ,constidVec3&,idVec3&,bool) | 23 | 1h 36min | 16min | __Globals.Brush_MoveVertex(brush_t* ,constidVec3&,constidVec3&,idVec3&,bool) |
| Map_SaveFile(constchar*,bool,bool) | 23 | 1h 36min | 16min | __Globals.Map_SaveFile(constchar*,bool ,bool) |
| Map_ImportBuffer(char*,bool) | 23 | 1h 36min | 16min | __Globals.Map_ImportBuffer(char*,bool) |
| ProcessDownloadRequestMessage (constnetadr_t,constidBitMsg&) | 23 | 1h 36min | 16min | idAsyncServer .ProcessDownloadRequestMessage (constnetadr_t,constidBitMsg&) |
| GravSubdivLeafNode(idBrushBSPNode*) | 23 | 1h 36min | 16min | idAASBuild.GravSubdivLeafNode (idBrushBSPNode*) |
| AddStrList(constchar*,idStrList*,bool) | 23 | 1h 36min | 16min | MaterialTreeView.AddStrList(constchar* ,idStrList*,bool) |
| PostParse() | 23 | 1h 36min | 16min | idListWindow.PostParse() |
| Rule Violated: Avoid methods with too many overloads |
• Rule Description:
Method overloading is the ability to create multiple methods of the same name with different implementations, and various set of parameters.
This rule matches sets of methods with 6 overloads or more.
Such method set might be a problem to maintain and provokes coupling higher than necessary.
See the definition of the NbOverloads metric here http://www.cppdepend.com/Metrics.aspx#NbOverloads
• How to Fix Issues: Typically the too many overloads phenomenon appears when an algorithm takes a various set of in-parameters. Each overload is presented as a facility to provide a various set of in-parameters. In such situation, the C# and VB.NET language feature named Named and Optional arguments should be used. The too many overloads phenomenon can also be a consequence of the usage of the visitor design pattern http://en.wikipedia.org/wiki/Visitor_pattern since a method named Visit() must be provided for each sub type. In such situation there is no need for fix. Sometime too many overloads phenomenon is not the symptom of a problem, for example when a numeric to something conversion method applies to all numeric and nullable numeric types. The estimated Debt, which means the effort to fix such issue, is of 2 minutes per method overload.
• How to Fix Issues: Typically the too many overloads phenomenon appears when an algorithm takes a various set of in-parameters. Each overload is presented as a facility to provide a various set of in-parameters. In such situation, the C# and VB.NET language feature named Named and Optional arguments should be used. The too many overloads phenomenon can also be a consequence of the usage of the visitor design pattern http://en.wikipedia.org/wiki/Visitor_pattern since a method named Visit() must be provided for each sub type. In such situation there is no need for fix. Sometime too many overloads phenomenon is not the symptom of a problem, for example when a numeric to something conversion method applies to all numeric and nullable numeric types. The estimated Debt, which means the effort to fix such issue, is of 2 minutes per method overload.
195 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 195 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 195 methods | overloads | Debt | Severity | Full Name |
|---|---|---|---|---|
| idStr() | 10 methods | 2min 0s | Medium | idStr.idStr() |
| idStr(constidStr&) | 10 methods | 2min 0s | Medium | idStr.idStr(constidStr&) |
| idStr(constidStr&,int,int) | 10 methods | 2min 0s | Medium | idStr.idStr(constidStr&,int,int) |
| idStr(constchar*) | 10 methods | 2min 0s | Medium | idStr.idStr(constchar*) |
| idStr(constchar*,int,int) | 10 methods | 2min 0s | Medium | idStr.idStr(constchar*,int,int) |
| idStr(constbool) | 10 methods | 2min 0s | Medium | idStr.idStr(constbool) |
| idStr(constchar) | 10 methods | 2min 0s | Medium | idStr.idStr(constchar) |
| idStr(constint) | 10 methods | 2min 0s | Medium | idStr.idStr(constint) |
| idStr(constunsignedint) | 10 methods | 2min 0s | Medium | idStr.idStr(constunsignedint) |
| idStr(constfloat) | 10 methods | 2min 0s | Medium | idStr.idStr(constfloat) |
| idEventArg() | 10 methods | 2min 0s | Medium | idEventArg.idEventArg() |
| idEventArg(int) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(int) |
| idEventArg(float) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(float) |
| idEventArg(idVec3&) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(idVec3&) |
| idEventArg(constidStr&) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(constidStr&) |
| idEventArg(constchar*) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(constchar*) |
| idEventArg(constclassidEntity*) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg (constclassidEntity*) |
| idEventArg(conststructtrace_s*) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg (conststructtrace_s*) |
| idEventArg(constidEventArg&) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(constidEventArg&) |
| idEventArg(idEventArg&&) | 10 methods | 2min 0s | Medium | idEventArg.idEventArg(idEventArg&&) |
| idEventArg() | 9 methods | 2min 0s | Medium | idEventArg.idEventArg() |
| idEventArg(int) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(int) |
| idEventArg(float) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(float) |
| idEventArg(idVec3&) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(idVec3&) |
| idEventArg(constidStr&) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(constidStr&) |
| idEventArg(constchar*) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(constchar*) |
| idEventArg(constclassidEntity*) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg (constclassidEntity*) |
| idEventArg(conststructtrace_s*) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg (conststructtrace_s*) |
| idEventArg(idEventArg&&) | 9 methods | 2min 0s | Medium | idEventArg.idEventArg(idEventArg&&) |
| PostEventMS(constidEventDef*,int) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ) |
| PostEventMS(constidEventDef*,int ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float) |
| PostEventSec(constidEventDef*,float ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef*) |
| ProcessEvent(constidEventDef*,idEventArg ) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ) |
| PostEventMS(constidEventDef*,int ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventMS(constidEventDef*,int ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float) |
| PostEventSec(constidEventDef*,float ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| PostEventSec(constidEventDef*,float ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.PostEventSec(constidEventDef* ,float,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef*) |
| ProcessEvent(constidEventDef*,idEventArg ) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) |
| ProcessEvent(constidEventDef*,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg) | 9 methods | 2min 0s | Medium | idClass.ProcessEvent(constidEventDef* ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg,idEventArg ,idEventArg,idEventArg) |
| Dot(float*,constidVec3&,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidVec3& ,constidVec3*,constint) |
| Dot(float*,constidVec3&,constidPlane* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidVec3& ,constidPlane*,constint) |
| Dot(float*,constidVec3&,constidDrawVert* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidVec3& ,constidDrawVert*,constint) |
| Dot(float*,constidPlane&,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidPlane& ,constidVec3*,constint) |
| Dot(float*,constidPlane&,constidPlane* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidPlane& ,constidPlane*,constint) |
| Dot(float*,constidPlane& ,constidDrawVert*,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidPlane& ,constidDrawVert*,constint) |
| Dot(float*,constidVec3*,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float*,constidVec3* ,constidVec3*,constint) |
| Dot(float&,constfloat*,constfloat* ,constint) | 8 methods | 2min 0s | Medium | idSIMDProcessor.Dot(float&,constfloat* ,constfloat*,constint) |
| Dot(float*,constidVec3&,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidVec3& ,constidVec3*,constint) |
| Dot(float*,constidVec3&,constidPlane* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidVec3& ,constidPlane*,constint) |
| Dot(float*,constidVec3&,constidDrawVert* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidVec3& ,constidDrawVert*,constint) |
| Dot(float*,constidPlane&,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidPlane& ,constidVec3*,constint) |
| Dot(float*,constidPlane&,constidPlane* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidPlane& ,constidPlane*,constint) |
| Dot(float*,constidPlane& ,constidDrawVert*,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidPlane& ,constidDrawVert*,constint) |
| Dot(float*,constidVec3*,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float*,constidVec3* ,constidVec3*,constint) |
| Dot(float&,constfloat*,constfloat* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_Generic.Dot(float&,constfloat* ,constfloat*,constint) |
| Dot(float*,constidVec3&,constidVec3* ,constint) | 8 methods | 2min 0s | Medium | idSIMD_SSE.Dot(float*,constidVec3& ,constidVec3*,constint) |
| Rule Violated: Avoid methods potentially poorly commented |
• Rule Description:
This rule matches methods with less than 20% of comment lines and that have at least 20 lines of code. Such method might need to be more commented.
See the definitions of the Comments metric here: http://www.cppdepend.com/Metrics.aspx#PercentageComment http://www.cppdepend.com/Metrics.aspx#NbLinesOfComment
Notice that only comments about the method implementation (comments in method body) are taken account.
• How to Fix Issues: Typically add more comment. But code commenting is subject to controversy. While poorly written and designed code would needs a lot of comment to be understood, clean code doesn't need that much comment, especially if variables and methods are properly named and convey enough information. Unit-Test code can also play the role of code commenting. However, even when writing clean and well-tested code, one will have to write hacks at a point, usually to circumvent some API limitations or bugs. A hack is a non-trivial piece of code, that doesn't make sense at first glance, and that took time and web research to be found. In such situation comments must absolutely be used to express the intention, the need for the hacks and the source where the solution has been found. The estimated Debt, which means the effort to comment such method, varies linearly from 2 minutes for 10 lines of code not commented, up to 20 minutes for 200 or more, lines of code not commented.
• How to Fix Issues: Typically add more comment. But code commenting is subject to controversy. While poorly written and designed code would needs a lot of comment to be understood, clean code doesn't need that much comment, especially if variables and methods are properly named and convey enough information. Unit-Test code can also play the role of code commenting. However, even when writing clean and well-tested code, one will have to write hacks at a point, usually to circumvent some API limitations or bugs. A hack is a non-trivial piece of code, that doesn't make sense at first glance, and that took time and web research to be found. In such situation comments must absolutely be used to express the intention, the need for the hacks and the source where the solution has been found. The estimated Debt, which means the effort to comment such method, varies linearly from 2 minutes for 10 lines of code not commented, up to 20 minutes for 200 or more, lines of code not commented.
1,957 methods matched
- The following list of methods is truncated and contains only the first 100 methods of the 1957 methods matched.
-
Formatting: bold means added, underlined means code was changed,
strike-boldmeans removed (since baseline)
| 1 957 methods | Percentage Comment | # lines of code (LOC) | # lines of comment | nbLinesOfCodeNotCommented | Debt | Annual Interest | Full Name |
|---|---|---|---|---|---|---|---|
| Execute() | 2.19 | 715 | 16 | 699 | 20min | 14min | idInterpreter.Execute() |
| Execute() | 2.19 | 715 | 16 | 699 | 20min | 14min | idInterpreter.Execute() |
| GLimp_EnableLogging(bool) | 2.62 | 706 | 19 | 687 | 20min | 14min | __Globals.GLimp_EnableLogging(bool) |
| QGL_Init(constchar*) | 2.39 | 368 | 9 | 359 | 20min | 14min | __Globals.QGL_Init(constchar*) |
| QGL_Shutdown() | 1.63 | 362 | 6 | 356 | 20min | 14min | __Globals.QGL_Shutdown() |
| Curl_gd_parse(void*) | 16.77 | 402 | 81 | 321 | 20min | 4min 15s | __Globals.Curl_gd_parse(void*) |
| TestMath() | 1.52 | 325 | 5 | 320 | 20min | 14min | __Globals.TestMath() |
| EvaluateTokens(idToken*,long*,double* ,int) | 6.76 | 345 | 25 | 320 | 20min | 11min | idParser.EvaluateTokens(idToken*,long* ,double*,int) |
| ParseStage(idLexer&,consttextureRepeat_t ) | 9.35 | 349 | 36 | 313 | 20min | 9min | idMaterial.ParseStage(idLexer& ,consttextureRepeat_t) |
| AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) | 5.33 | 320 | 18 | 302 | 20min | 12min | idAnim.AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) |
| dradbg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 0 | 270 | 0 | 270 | 20min | 16min | __Globals.dradbg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| InverseSelf() | 5.76 | 278 | 17 | 261 | 20min | 11min | idMat6.InverseSelf() |
| AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) | 6.06 | 279 | 18 | 261 | 20min | 11min | idAnim.AddFrameCommand (constclassidDeclModelDef*,int,idLexer& ,constidDict*) |
| HandleMainMenuCommands(constchar*) | 11.9 | 296 | 40 | 256 | 20min | 7min | idSessionLocal.HandleMainMenuCommands (constchar*) |
| dradfg(int,int,int,int,float*,float* ,float*,float*,float*,float*) | 0 | 248 | 0 | 248 | 20min | 16min | __Globals.dradfg(int,int,int,int,float* ,float*,float*,float*,float*,float*) |
| HandleCommand(WPARAM,LPARAM) | 3.88 | 248 | 10 | 238 | 20min | 13min | rvGEApp.HandleCommand(WPARAM,LPARAM) |
| HessenbergToRealSchur(idMatX&,idVecX& ,idVecX&) | 12.16 | 260 | 36 | 224 | 20min | 7min | idMatX.HessenbergToRealSchur(idMatX& ,idVecX&,idVecX&) |
| Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) | 10.51 | 247 | 29 | 218 | 20min | 8min | idSurface.Split(constidPlane&,constfloat ,idSurface**,idSurface**,int*,int*) |
| lwGetSurface5(idFile*,int,lwObject*) | 6.77 | 234 | 17 | 217 | 20min | 11min | __Globals.lwGetSurface5(idFile*,int ,lwObject*) |
| ParseScope(constchar*,bool,idParser& ,idClassTypeInfo*) | 8.95 | 234 | 23 | 211 | 20min | 9min | idTypeInfoGen.ParseScope(constchar*,bool ,idParser&,idClassTypeInfo*) |
| Parse(idParser*,bool) | 17.61 | 262 | 56 | 206 | 20min | 3min 40s | idWindow.Parse(idParser*,bool) |
| Restore(idRestoreGame*) | 4.82 | 217 | 11 | 206 | 20min | 12min | idPlayer.Restore(idRestoreGame*) |
| CallFrameCommands(idEntity*,int,int) | 2.35 | 208 | 5 | 203 | 20min | 14min | idAnim.CallFrameCommands(idEntity*,int ,int) |
| GetWeaponDef(constchar*,int) | 9.88 | 228 | 25 | 203 | 20min | 9min | idWeapon.GetWeaponDef(constchar*,int) |
| DeriveTangents(idPlane*,idDrawVert* ,constint,constint*,constint) | 11.02 | 226 | 28 | 198 | 19min | 8min | idSIMD_SSE.DeriveTangents(idPlane* ,idDrawVert*,constint,constint*,constint ) |
| ParseSingleFXAction(idLexer& ,idFXSingleAction&) | 8 | 207 | 18 | 189 | 18min | 10min | idDeclFX.ParseSingleFXAction(idLexer& ,idFXSingleAction&) |
| CallFrameCommands(idEntity*,int,int) | 2.53 | 193 | 5 | 188 | 18min | 14min | idAnim.CallFrameCommands(idEntity*,int ,int) |
| dprintf_formatf(void*,int(*)(int,FILE*) ,constchar*,va_list) | 19.32 | 238 | 57 | 181 | 18min | 2min 28s | __Globals.dprintf_formatf(void*,int(*) (int,FILE*),constchar*,va_list) |
| OptimizeOpcode(constopcode_t*,idVarDef* ,idVarDef*) | 3.68 | 183 | 7 | 176 | 17min | 13min | idCompiler.OptimizeOpcode(constopcode_t* ,idVarDef*,idVarDef*) |
| OptimizeOpcode(constopcode_t*,idVarDef* ,idVarDef*) | 3.68 | 183 | 7 | 176 | 17min | 13min | idCompiler.OptimizeOpcode(constopcode_t* ,idVarDef*,idVarDef*) |
| Restore(idRestoreGame*) | 5.61 | 185 | 11 | 174 | 17min | 12min | idPlayer.Restore(idRestoreGame*) |
| MatX_MultiplyMatX(idMatX&,constidMatX& ,constidMatX&) | 12.93 | 202 | 30 | 172 | 17min | 6min | idSIMD_Generic.MatX_MultiplyMatX(idMatX& ,constidMatX&,constidMatX&) |
| inflate_blocks(inflate_blocks_statef* ,z_streamp,int) | 9.57 | 189 | 20 | 169 | 16min | 9min |